Node 12?

[chadbr]

Node 12 is out -- any plans to support it?

Several minimum compiler changes... hopefully they don't cause you many issues.

https://medium.com/@nodejs/introducing-node-js-12-76c41a1b3f3f

Thanks, Chad

[rimmartin]

Sure, I'll check on it

[rimmartin]

Looking it over I think I should do it in branch. Then worry about publishing later. Publishing is changing in the ecosystem anyway

[rimmartin]

branch v12 compiles and runs the tests successfully.

Next to update code for all the deprecation warnings

[chadbr]

Awesome 👏

[chadbr]

Hey @rimmartin we were looking into upgrading to node 12.

Any thoughts on merging the branch? Or a way forward?

Thanks, Chad

[rimmartin]

Hi @chadbr,
You would like it to come from npm repository?

I don't have a develop branch but could merge to a develop branch for a while

Have to think about it; I know there are some more deprecated v8 functions/objects I need to upgrade but these don't effect the javascript side

[chadbr]

@rimmartin moving to 12 was my assumption yes. Increment major version number - document it's a move to v12.

For v10 support, may you branch master to a v10 branch and only increment minor version there if you wan to fix?

What were you thinking?

[rimmartin]

Yea I'm inclined to do that.

May publish for the prior versions one more time to npm (with some fixes) and then immediately publish for v12 and beyond

[rimmartin]

working with v13 as well And also travis now allows building for windows; adding that

[chadbr]

beautiful -- thanks much.

[ashaffer]

Hello, just wonder if there's been any movement on merging this into the main package? I'd like to use it in node 12.

[rimmartin]

Hi @ashaffer I'll begin to publish this week; been working on downstream uses

[chadbr]

Thanks for your continued hard work @rimmartin

fwiw @ashaffer we've been pulling directly from the branch since we moved to node 12.

    "hdf5": "git+https://git@github.com/HDF-NI/hdf5.node.git#v12",

[rimmartin]

@chadbr thank you:-) I got a little bit away working on refurbishing the nvd3 charting based on d3 v5
https://github.com/rimmartin/nvd3 http://nvd3.org/
to be able to use in the hdf5.viewer
I also have been making hdf5.ws and hdf5.uws(which goes directly from hdf5 to the web based on c++ https://github.com/uNetworking/uWebSockets server) usable and publishable.

But the nvd3 is taking a lot more so I'll punt and publish hdf5.node before I finish these dependent projects)

[chadbr]

Looks like node 14 is out :)