Fix gemini suggestions and lint more import order.

Author: XrossFox

logging/samples/snippets/snippets.py

@@ -24,14 +24,14 @@
 import argparse
 import time
 
-import logging
-
 import google.cloud.logging
 
+import logging
+
 
 # [START logging_write_log_entry]
 def write_entry():
-    """Writes log entries to the given logger."""
+    """Writes log entries to the default logger."""
     logging_client = google.cloud.logging.Client()
 
     # By default, all logs sent through setup_logging()

logging/samples/snippets/snippets_test.py

@@ -25,7 +25,7 @@
 TEST_LOGGER_NAME = "example_log_{}".format(uuid.uuid4().hex)
 TEST_TEXT = "Hello, world."
 GOOGLE_CLOUD_PROJECT = os.getenv("GOOGLE_CLOUD_PROJECT")
-DEFAULT_LOG_ID = f"projects/{GOOGLE_CLOUD_PROJECT}/logs/python"
+DEFAULT_LOGGER = f"projects/{GOOGLE_CLOUD_PROJECT}/logs/python"
 
 
 @pytest.fixture
@@ -56,18 +56,17 @@ def eventually_consistent_test():
         # retrieve logs
         client = logging.Client()
 
-        log_filter = DEFAULT_LOG_ID
+        log_filter = DEFAULT_LOGGER
 
         entries = client.list_entries(
             filter_=log_filter, order_by=logging.DESCENDING, max_results=3
         )
 
-        entry_1 = next(entries)
-        assert entry_1.payload["message"] == "This is a JSON log."
-        entry_2 = next(entries)
-        assert entry_2.payload == "Goodbye, world!"
-        entry_3 = next(entries)
-        assert entry_3.payload == "Hello, world!"
+        retrieved_entries = list(entries)
+
+        assert retrieved_entries[0].payload["message"] == "This is a JSON log."
+        assert retrieved_entries[1].payload == "Goodbye, world!"
+        assert retrieved_entries[2].payload == "Hello, world!"
 
     eventually_consistent_test()