Commit af50de3
matthew
hygiene: five public lines described how the code was built, not what it does
public-hygiene-lint went red on the merged tree. Every hit arrived today and
each is the same mistake in a different dress: prose written for the next
maintainer, in a file a customer can read.
plane/mod.rs addressed "the next person to ask is this still dead" - a
sentence about the reader rather than about the software. It now states the
fact instead: wire_formats has two callers, and this header is what says
whether a member of this module is reachable.
The differential test carried bare (D2) and (D3) audit identifiers. A
two-character finding id is meaningless outside the document that assigned it,
and that document is not published. The fixtures are named either way, so the
ids carried nothing the sentence did not.
structure-lint cited (§A7), (§A6), (§8.1) and (§10.4 step 15) - four pointers
into design documents a public reader cannot open. The invariants are named in
the script itself, so the citations were decoration.
Not fixed by an allow-list entry. Every one of these was rewritable, and the
lint is worth more when the escape hatch stays unused.
Also confirmed while here: the gate failure on `cargo test
--no-default-features --locked` was a FLAKE under concurrent load, not a
regression. Two consecutive clean runs, exit 0, 4287 passed / 0 failed across
40 binaries. The panic line in that output is hook-test-plugin deliberately
panicking to prove dlopen is fail-closed.1 parent a5b48fd commit af50de3
3 files changed
Lines changed: 11 additions & 12 deletions
File tree
- crates/busbar/src
- plane
- proxy/tests
- scripts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
| |||
Lines changed: 5 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
669 | 669 | | |
670 | 670 | | |
671 | 671 | | |
672 | | - | |
673 | | - | |
674 | | - | |
675 | | - | |
676 | | - | |
677 | | - | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
678 | 677 | | |
679 | 678 | | |
680 | 679 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
1339 | 1339 | | |
1340 | 1340 | | |
1341 | 1341 | | |
1342 | | - | |
| 1342 | + | |
1343 | 1343 | | |
1344 | 1344 | | |
1345 | 1345 | | |
| |||
0 commit comments