Fixing more tests.

Author: corbett5

inputFiles/lagrangianContactMechanics/TFrac_smoke.xml

@@ -17,14 +17,6 @@
 <!-- SPHINX_SOLVER_END -->
 </Solvers>
 
-  <NumericalMethods>
-    <FiniteElements>
-      <FiniteElementSpace
-        name="FE1"
-        order="1"/>
-    </FiniteElements>
-  </NumericalMethods>
-
   <!-- SPHINX_MESH -->
   <Mesh>
     <InternalMesh

inputFiles/wavePropagation/acous3D_firstOrder_fs_smoke.xml

@@ -25,13 +25,4 @@
       xMin="{ -0.01, -0.01, 100.99 }"
       xMax="{ 101.01, 101.01, 101.01 }"/>
   </Geometry>
-
-    <!-- The free surface condition the domain -->
-  <FieldSpecifications>
-    <FieldSpecification
-      name="zposFreeSurface"
-      objectPath="faceManager"
-      fieldName="FreeSurface"
-      setNames="{ zpos }"/>
-  </FieldSpecifications>
 </Problem>

src/coreComponents/mesh/ElementRegionManager.cpp

@@ -93,12 +93,7 @@ void ElementRegionManager::expandObjectCatalogs()
 {
   for( string const & key : getUserAvailableKeys() )
   {
-    Group & elementRegions = this->getGroup( ElementRegionManager::groupKeyStruct::elementRegionsGroup() );
-
-    std::unique_ptr< Group > region =
-      CatalogInterface::factory( key, getDataContext(), key, &elementRegions );
-
-    elementRegions.registerGroup( std::move( region ), true );
+    this->createChild( key, key, true );
   }
 }
 
@@ -275,6 +270,7 @@ void ElementRegionManager::buildSets( NodeManager const & nodeManager )
       arrayView1d< bool const > const nodeInCurSet = nodeInSet[setName];
 
       SortedArray< localIndex > & targetSet = elementSets.registerWrapper< SortedArray< localIndex > >( setName, true ).reference();
+      targetSet.clear();
       for( localIndex k = 0; k < subRegion.size(); ++k )
       {
         localIndex const numNodes = subRegion.numNodesPerElement( k );

src/coreComponents/mesh/ObjectManagerBase.cpp

@@ -89,14 +89,9 @@ ObjectManagerBase::CatalogInterface::CatalogType & ObjectManagerBase::getCatalog
 
 SortedArray< localIndex > & ObjectManagerBase::createSet( const string & newSetName )
 {
-  if( m_sets.hasWrapper( newSetName ) )
-  {
-    return m_sets.getReference< SortedArray< localIndex > >( newSetName );
-  }
-  else
-  {
-    return m_sets.registerWrapper< SortedArray< localIndex > >( newSetName ).reference();
-  }
+  auto & set = m_sets.registerWrapper< SortedArray< localIndex > >( newSetName, true ).reference();
+  set.clear();
+  return set;
 }
 
 void ObjectManagerBase::constructSetFromSetAndMap( SortedArrayView< localIndex const > const & inputSet,

src/coreComponents/mesh/ObjectManagerBase.hpp

@@ -574,7 +574,7 @@ class ObjectManagerBase : public dataRepository::Group
 
     m_registeredField.insert( FIELD_TRAIT::key());
 
-    return this->registerWrapper< typename FIELD_TRAIT::type >( FIELD_TRAIT::key() ).
+    return this->registerWrapper< typename FIELD_TRAIT::type >( FIELD_TRAIT::key(), nullptr, true ).
              setApplyDefaultValue( defaultValue ).
              setPlotLevel( FIELD_TRAIT::plotLevel ).
              setRestartFlags( FIELD_TRAIT::restartFlag ).

src/coreComponents/mesh/ParticleManager.cpp

@@ -102,12 +102,7 @@ void ParticleManager::expandObjectCatalogs()
     string const key = iter->first;
     if( key.find( "ParticleRegion" ) != string::npos )
     {
-      Group & particleRegions = this->getGroup( ParticleManager::groupKeyStruct::particleRegionsGroup() );
-
-      std::unique_ptr< Group > region =
-        CatalogInterface::factory( key, getDataContext(), key, &particleRegions );
-
-      particleRegions.registerGroup( std::move( region ), true );
+      this->createChild( key, key, true );
     }
   }
 }

src/coreComponents/physicsSolvers/PhysicsSolverBase.hpp

@@ -1264,12 +1264,12 @@ string PhysicsSolverBase::getConstitutiveName( ParticleSubRegionBase const & sub
 template< typename CONSTITUTIVE >
 void PhysicsSolverBase::setConstitutiveName( ElementSubRegionBase & subRegion, string const & wrapperName, string const & constitutiveType ) const
 {
-  subRegion.registerWrapper< string >( wrapperName ).
-    setPlotLevel( dataRepository::PlotLevel::NOPLOT ).
-    setRestartFlags( dataRepository::RestartFlags::NO_WRITE ).
-    setSizedFromParent( 0 );
+  string & constitutiveName = subRegion.registerWrapper< string >( wrapperName, true ).
+                                setPlotLevel( dataRepository::PlotLevel::NOPLOT ).
+                                setRestartFlags( dataRepository::RestartFlags::NO_WRITE ).
+                                setSizedFromParent( 0 ).
+                                reference();
 
-  string & constitutiveName = subRegion.getReference< string >( wrapperName );
   constitutiveName = getConstitutiveName< CONSTITUTIVE >( subRegion );
   GEOS_ERROR_IF( constitutiveName.empty(), GEOS_FMT( "{}: {} constitutive model not found on subregion {}",
                                                      getDataContext(), constitutiveType, subRegion.getName() ) );

src/coreComponents/physicsSolvers/fluidFlow/CompositionalMultiphaseBase.cpp

@@ -1289,7 +1289,7 @@ void CompositionalMultiphaseBase::computeHydrostaticEquilibrium( DomainPartition
       // Step 3.5: create hydrostatic pressure table
 
       string const tableName = fs.getName() + "_" + subRegion.getName() + "_" + phaseNames[ipInit] + "_table";
-      TableFunction * const presTable = dynamicCast< TableFunction * >( functionManager.createChild( TableFunction::catalogName(), tableName ) );
+      TableFunction * const presTable = dynamicCast< TableFunction * >( functionManager.createChild( TableFunction::catalogName(), tableName, true ) );
       presTable->setTableCoordinates( elevationValues, { units::Distance } );
       presTable->setTableValues( pressureValues, units::Pressure );
       presTable->setInterpolationMethod( TableFunction::InterpolationType::Linear );

src/coreComponents/schema/schema.xsd.other

@@ -516,7 +516,7 @@
 		<!--fractureStencil => (no description available)-->
 		<xsd:attribute name="fractureStencil" type="geos_SurfaceElementStencil" />
 		<!--targetRegions => List of regions to build the stencil for-->
-		<xsd:attribute name="targetRegions" type="geos_mapBase_lt_string_cm_-geos_internal_StdVectorWrapper_lt_string_cm_-std_allocator_lt_string-_gt__cm_-true_gt__cm_-std_integral_constant_lt_bool_cm_-true_gt_-_gt_" />
+		<xsd:attribute name="targetRegions" type="geos_mapBase_lt_string_cm_-geos_internal_StdVectorWrapper_lt_string_cm_-std_allocator_lt_string-_gt__cm_-false_gt__cm_-std_integral_constant_lt_bool_cm_-true_gt_-_gt_" />
 	</xsd:complexType>
 	<xsd:complexType name="OutputsType">
 		<xsd:choice minOccurs="0" maxOccurs="unbounded">
@@ -1508,7 +1508,7 @@
 			<xsd:element name="MeshBodies" type="MeshBodiesType" />
 		</xsd:choice>
 		<!--Neighbors => (no description available)-->
-		<xsd:attribute name="Neighbors" type="geos_internal_StdVectorWrapper_lt_geos_NeighborCommunicator_cm_-std_allocator_lt_geos_NeighborCommunicator_gt__cm_-true_gt_" />
+		<xsd:attribute name="Neighbors" type="geos_internal_StdVectorWrapper_lt_geos_NeighborCommunicator_cm_-std_allocator_lt_geos_NeighborCommunicator_gt__cm_-false_gt_" />
 		<!--partitionManager => (no description available)-->
 		<xsd:attribute name="partitionManager" type="geos_PartitionBase" />
 	</xsd:complexType>