Fix Lao profile finite-difference inputs

Author: nicamo

freegsnke/nonlinear_solve.py

@@ -38,7 +38,6 @@
 from .Myy_builder import Myy_handler
 from .simplified_solve import simplified_solver_J1
 
-
 _parallel_linearization_solver = None
 
 
@@ -1784,7 +1783,7 @@ def _build_dIydI_columns(
             del self._column_plasma_descriptor_function
 
     def _profile_parameters_for_column(self, profiles, j, delta):
-        """Return a complete profile-parameter set with column ``j`` perturbed."""
+        """Return independent profile parameters with column ``j`` perturbed."""
         if self.profiles_param is not None:
             parameters = {
                 "alpha_m": profiles.alpha_m,
@@ -1795,17 +1794,13 @@ def _profile_parameters_for_column(self, profiles, j, delta):
             parameters[parameter_name] += delta
             return parameters
 
-        alpha = profiles.alpha.copy()
-        beta = profiles.beta.copy()
+        alpha = profiles.alpha[: self.n_profiles_parameters_alpha].copy()
+        beta = profiles.beta[: self.n_profiles_parameters_beta].copy()
         if j < self.n_profiles_parameters_alpha:
             alpha[j] += delta
-            if profiles.alpha_logic:
-                alpha[-1] -= delta
         else:
             beta_index = j - self.n_profiles_parameters_alpha
             beta[beta_index] += delta
-            if profiles.beta_logic:
-                beta[-1] -= delta
         return {"alpha": alpha, "beta": beta}
 
     def _profile_parameter_name(self, j):

freegsnke/tests/test_linearisation_perturbations.py

@@ -185,10 +185,11 @@ def test_dIydI_columns_preserve_order_with_multiple_workers(monkeypatch):
     assert results == [4, 2, 3]
 
 
-def test_profile_parameter_shift_preserves_lao_constraints():
+def test_profile_parameter_shift_supplies_independent_lao_coefficients():
     solver = bare_solver()
     solver.profiles_param = None
     solver.n_profiles_parameters_alpha = 2
+    solver.n_profiles_parameters_beta = 1
     profiles = SimpleNamespace(
         alpha=np.array([1.0, 2.0, -3.0]),
         beta=np.array([4.0, -4.0]),
@@ -199,10 +200,10 @@ def test_profile_parameter_shift_preserves_lao_constraints():
     alpha_shift = solver._profile_parameters_for_column(profiles, 1, 0.25)
     beta_shift = solver._profile_parameters_for_column(profiles, 2, 0.5)
 
-    np.testing.assert_allclose(alpha_shift["alpha"], [1.0, 2.25, -3.25])
-    np.testing.assert_allclose(alpha_shift["beta"], profiles.beta)
-    np.testing.assert_allclose(beta_shift["alpha"], profiles.alpha)
-    np.testing.assert_allclose(beta_shift["beta"], [4.5, -4.5])
+    np.testing.assert_allclose(alpha_shift["alpha"], [1.0, 2.25])
+    np.testing.assert_allclose(alpha_shift["beta"], [4.0])
+    np.testing.assert_allclose(beta_shift["alpha"], [1.0, 2.0])
+    np.testing.assert_allclose(beta_shift["beta"], [4.5])
     np.testing.assert_allclose(profiles.alpha, [1.0, 2.0, -3.0])
     np.testing.assert_allclose(profiles.beta, [4.0, -4.0])