Skip to content

Commit 2bb04ce

Browse files
terminate on comparator errors and add more logging (Coverity CID 1700533)
Signed-off-by: ethan-thompson <ethan.thompson@networkradius.com>
1 parent e82f0ab commit 2bb04ce

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

src/modules/rlm_linelog/file.c

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,13 @@ void file_batching_xlat_handle_signal(xlat_ctx_t const *xctx, request_t *request
9696

9797
static int _file_free(rlm_linelog_file_t *file)
9898
{
99-
(void) fr_hash_table_delete(file->thread_inst->file_table, file);
99+
int ret;
100+
101+
ret = fr_hash_table_delete(file->thread_inst->file_table, file);
102+
103+
fr_fatal_assert_msg(ret >= 0, "Failed removing \"%s\" from file_table: %s", file->filename, fr_strerror());
104+
105+
fr_cond_assert_msg(ret == 0, "file_table delete for \"%s\" returned \"not found\"", file->filename);
100106

101107
return 0;
102108
}

0 commit comments

Comments
 (0)