Skip to content

Commit a39d0cb

Browse files
fix secret key substitution
1 parent 4172fea commit a39d0cb

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

raveandroid/src/main/java/com/flutterwave/raveandroid/account/AccountFragment.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
import android.widget.LinearLayout;
3131
import android.widget.TextView;
3232
import android.widget.Toast;
33-
import com.flutterwave.raveandroid.RaveConstants;
3433
import com.flutterwave.raveandroid.Payload;
3534
import com.flutterwave.raveandroid.PayloadBuilder;
3635
import com.flutterwave.raveandroid.R;
@@ -124,6 +123,8 @@ public final String transformUrl(final Matcher match, String url) {
124123
otpLayout = (LinearLayout) v.findViewById(R.id.OTPBottomSheet);
125124
bottomSheetBehaviorOTP = BottomSheetBehavior.from(otpLayout);
126125

126+
ravePayInitializer = ((RavePayActivity) getActivity()).getRavePayInitializer();
127+
127128
bankEt.setOnClickListener(new View.OnClickListener() {
128129
@Override
129130
public void onClick(View v) {
@@ -149,13 +150,11 @@ public void onClick(View v) {
149150
if (otp.length() < 1) {
150151
otpTil.setError("Enter a valid one time password");
151152
} else {
152-
presenter.validateAccountCharge(flwRef, otp, RaveConstants.PUBLIC_KEY);
153+
presenter.validateAccountCharge(flwRef, otp, ravePayInitializer.getPublicKey());
153154
}
154155
}
155156
});
156157

157-
ravePayInitializer = ((RavePayActivity) getActivity()).getRavePayInitializer();
158-
159158
if (Utils.isEmailValid(ravePayInitializer.getEmail())) {
160159
emailTil.setVisibility(GONE);
161160
emailEt.setText(ravePayInitializer.getEmail());
@@ -211,7 +210,8 @@ private void validateDetails() {
211210
}
212211

213212
if (amount.length() == 0) {
214-
amount = "50";
213+
valid = false;
214+
showToast("Amount is required");
215215
}
216216

217217
if (selectedBank == null) {
@@ -235,6 +235,8 @@ private void validateDetails() {
235235

236236
Payload body = builder.createBankPayload();
237237
body.setPhonenumber(phone);
238+
body.setPBFSecKey(ravePayInitializer.getSecretKey());
239+
body.setSECKEY(ravePayInitializer.getSecretKey());
238240

239241
if (selectedBank.isInternetbanking()) {
240242
body.setIs_internet_banking("1");

raveandroid/src/main/java/com/flutterwave/raveandroid/account/AccountPresenter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,9 @@ public void onError(String message) {
5858
public void chargeAccount(final Payload payload, final boolean internetBanking) {
5959

6060
String cardRequestBodyAsString = Utils.convertChargeRequestPayloadToJson(payload);
61-
String encryptedCardRequestBody = Utils.getEncryptedData(cardRequestBodyAsString, RaveConstants.PRIVATE_KEY);
61+
String encryptedCardRequestBody = Utils.getEncryptedData(cardRequestBodyAsString, payload.getPBFSecKey());
6262

63-
Log.d("encrypted", encryptedCardRequestBody);
63+
// Log.d("encrypted", encryptedCardRequestBody);
6464

6565
ChargeRequestBody body = new ChargeRequestBody();
6666
body.setAlg("3DES-24");

0 commit comments

Comments
 (0)