From b33ebe2b2dd9844c94ddb2103b90f01802275eae Mon Sep 17 00:00:00 2001 From: javier-gracia-tabuenca-tuni Date: Tue, 13 May 2025 10:32:19 +0300 Subject: [PATCH 1/2] Refactor buildStatusDashboard to read news file content into a variable for improved clarity and usability. --- R/buildStatusDashboard.R | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/R/buildStatusDashboard.R b/R/buildStatusDashboard.R index b6c6243..e61b724 100644 --- a/R/buildStatusDashboard.R +++ b/R/buildStatusDashboard.R @@ -70,6 +70,8 @@ buildStatusDashboard <- function( if (nrow(vocabularyTibble) != 0) { usagiTibble <- readUsagiFile(file.path(pathToVocabularyFolder, vocabularyTibble$path_to_usagi_file[1])) pathToNewsFile <- file.path(pathToVocabularyFolder, vocabularyTibble$path_to_news_file[1]) + newsFile <- readLines(pathToNewsFile) |> + paste0(collapse = "\n") nMapped <- usagiTibble |> dplyr::distinct(sourceCode, .keep_all = TRUE) |> dplyr::filter(mappingStatus == "APPROVED") |> @@ -97,7 +99,7 @@ buildStatusDashboard <- function( usagiTibble = usagiTibble, sourceVocabularyId = sourceVocabularyId, outputFolderPath = outputFolderPath, - pathToNewsFile = pathToNewsFile + newsFile = newsFile ) # create summary for all databases From 9f898de06e6ca381a34d63e63140d7c5e8f4eeec Mon Sep 17 00:00:00 2001 From: javier-gracia-tabuenca-tuni Date: Tue, 13 May 2025 11:41:48 +0300 Subject: [PATCH 2/2] sss --- R/buildStatusDashboard.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/buildStatusDashboard.R b/R/buildStatusDashboard.R index e61b724..6aa747a 100644 --- a/R/buildStatusDashboard.R +++ b/R/buildStatusDashboard.R @@ -99,7 +99,7 @@ buildStatusDashboard <- function( usagiTibble = usagiTibble, sourceVocabularyId = sourceVocabularyId, outputFolderPath = outputFolderPath, - newsFile = newsFile + pathToNewsFile = pathToNewsFile ) # create summary for all databases