fix(tests): make integration tests pass on macOS (#1091)

* fix(tests): make integration tests pass on macOS

On macOS with KqueueSelector, `asyncio.open_connection` returns before
the server-side accept callback registers the connection in
`ctx.connections`. Three tests in test_servercontext.py raced this
scheduling difference and failed deterministically on macOS while
passing on Linux CI.

- test_unexpected_exception: yield via exhaust_callbacks so the server
  task emits the "Exception in protocol" log before caplog is checked.
- test_drain_connections / test_connection_broken_external: poll
  ctx.connections until populated before depending on it. exhaust_callbacks
  cannot be used inside @fast_forward — the outer ticker keeps
  rescheduling itself and the inner exhaust never exits.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(tests): wait for queue boundary in test_info_message

`matchmaker_info` is broadcast by the periodic `report_dirties` ticker.
On macOS the first broadcast after `game_matchmaking` could be the
startup one (queue dirty but no searcher → empty boundary), making the
[[300, 700]] assertion fail. Wait for a matchmaker_info where the
tmm2v2 queue actually carries a non-empty boundary before asserting.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* refactor(tests): bound the connection-registration wait

Address CodeRabbit feedback: replace `while not ctx.connections` spin
loops with a helper that polls up to a fixed iteration count and raises
AssertionError on exhaustion, so tests fail fast instead of hanging if
the server never registers the connection.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: Brutus5000

tests/integration_tests/test_servercontext.py

@@ -12,6 +12,16 @@
 from tests.utils import exhaust_callbacks, fast_forward
 
 
+async def wait_for_connection_registered(ctx, max_iters=1000):
+    for _ in range(max_iters):
+        if ctx.connections:
+            return
+        await asyncio.sleep(0)
+    raise AssertionError(
+        "Server did not register the connection within the allotted iterations"
+    )
+
+
 class MockConnection:
     def __init__(self):
         self.protocol = None
@@ -91,6 +101,7 @@ async def test_connection_broken_external(context):
     """
     srv, ctx = context
     _, writer = await asyncio.open_connection(*srv.sockets[0].getsockname())
+    await wait_for_connection_registered(ctx)
     writer.close()
     # Need this sleep for test to work, otherwise closed protocol isn't detected
     await asyncio.sleep(0)
@@ -119,6 +130,7 @@ async def test_unexpected_exception(context, caplog, mocker):
 
     with caplog.at_level("TRACE"):
         _, writer = await asyncio.open_connection(*srv.sockets[0].getsockname())
+        await exhaust_callbacks()
 
     with closing(writer):
         assert "Exception in protocol" in caplog.text
@@ -144,6 +156,7 @@ async def test_unexpected_exception_in_connection_lost(context, caplog):
 async def test_drain_connections(context):
     srv, ctx = context
     _, writer = await asyncio.open_connection(*srv.sockets[0].getsockname())
+    await wait_for_connection_registered(ctx)
 
     with pytest.raises(asyncio.TimeoutError):
         await asyncio.wait_for(

tests/integration_tests/test_teammatchmaker.py

@@ -79,7 +79,15 @@ async def test_info_message(lobby_server):
         "mod": "tmm2v2"
     })
 
-    msg = await read_until_command(proto, "matchmaker_info")
+    def tmm2v2_populated(msg):
+        if msg["command"] != "matchmaker_info":
+            return False
+        return any(
+            q["queue_name"] == "tmm2v2" and q["boundary_80s"]
+            for q in msg.get("queues", [])
+        )
+
+    msg = await read_until(proto, tmm2v2_populated)
 
     assert msg["queues"]
     for queue in msg["queues"]: