Add vcpkg port for fesapi

[philippeVerney]

See microsoft/vcpkg#46809

From @NicolasCami in #361

Currently, the CMake configure seems to fail because the CI of vcpkg forces hdf5's "parallel" feature, and in the CMakeFiles you check HDF5_IS_PARALLEL: if true, you throw a FATAL_ERROR. I don't know HDF5, but according to the documentation this variable indicates that "HDF5 library has parallel IO support", I understand that (maybe) parallel IO is possible but not mandatory?

[NicolasCami]

Thanks for opening this issue. In the meantime I applied a suggestion from a reviewer in microsoft/vcpkg#46809, adding -DHDF5_PREFER_PARALLEL=${HDF5_WITH_PARALLEL} so that fesapi build has both HDF5_PREFER_PARALLEL and HDF5_WITH_PARALLEL variables set to true. I hope it fixes this issue.

[NicolasCami]

Hi @philippeVerney !

Adding -DHDF5_PREFER_PARALLEL=${HDF5_WITH_PARALLEL} option to portfile seems to solve the "parallel" issue. But we still have a bit of work to make it work for every configuration!

I just had a quick look at failed build, both static and dynamic linkage, for windows x64 (More information here:

• Dynamic linkage seems to fail at compile (ninja) step, but I don't have much clues. The relevant log file only contains ninja: error: build.ninja:6: lexing error
• Static linkage fails at configure step with TARGET_PDB_FILE is allowed only for targets with linker created artifacts. I think the following block in the main CMakeLists.txt should be restricted to something else (maybe WIN32 is not enough for vcpkg CI?):

if (WIN32)
	#PDB for debug
	INSTALL (
		FILES $<TARGET_PDB_FILE:${CPP_LIBRARY_NAME}>
		CONFIGURATIONS Debug RelWithDebInfo
		DESTINATION ${CMAKE_INSTALL_BINDIR}
		OPTIONAL
	)
endif (WIN32)

Kind regards

[philippeVerney]

Hi @NicolasCami

I don't think adding -DHDF5_PREFER_PARALLEL=${HDF5_WITH_PARALLEL} is a good solution since parallel usage is not the common one. I think the proposed solution to relax somehow the CMakeFiles is better : 3ce490c

I don't know neither about the Dynamic linkage issue and I am in hurry on some other topics for now.

I'll need to investigate about pdb. Sorry for my lack of time but I really have not for that for now.

[NicolasCami]

Hi @philippeVerney

3ce490c looks better indeed. No worries for the delay, we have a custom vcpkg registry to build fesapi so microsoft/vcpkg#46809 is not a blocker for us.

[NicolasCami]

According to this thread: TARGET_PDB_FILE does not work on MSVC static libraries, we probably want to install TARGET_PDB_FILE for dynamic lib and TARGET_COMPILE_PDB_FILE for static lib.

[philippeVerney]

I could reproduce and fix the build errors regarding HDF5_PREFER_PARALLEL and TARGET_PDB_FILE with the two commits previously mentioned in this thread.
I try to understand the last one :

Dynamic linkage seems to fail at compile (ninja) step, but I don't have much clues. The relevant log file only contains ninja: error: build.ninja:6: lexing error

I cannot reproduce it so far on my latop and I don't see anywhere lexing error in the pipeline output. How did you see this lexing error please?

[NicolasCami]

Hi @philippeVerney

Unfortunately the Azure Devops URL from here give me a "Build not found." error. It will be hard to fix that without the CI logs

[philippeVerney]

Yes it was deleted just some hours after my message..
I think I am going to release v2.13.1.0 like this and update the PR to hope to see more logs...

[philippeVerney]

Hi @NicolasCami

I just released a new v2.14.0.0.
If you can update your vcpk port when you'll have time, it would be good to see the new build errors if any (mainly the ninja lexing error):

• HDF5 issue should be solved
• PDB install should be solved

Thanks