Remove leading zeros from signature r and s (#173)

Author: alisinabh

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## Unreleased
+
+### Bug Fixes
+
+- Remove leading zeros from signature r and s values
+
 ## v0.6.0 (2025-01-01)
 
 ### Breaking Changes

lib/ethers/transaction/signed.ex

@@ -160,6 +160,8 @@ defmodule Ethers.Transaction.Signed do
   end
 
   defimpl Transaction.Protocol do
+    import Ethers.Utils, only: [remove_leading_zeros: 1]
+
     def type_id(signed_tx), do: Transaction.Protocol.type_id(signed_tx.pyalod)
 
     def type_envelope(signed_tx), do: Transaction.Protocol.type_envelope(signed_tx.payload)
@@ -171,7 +173,11 @@ defmodule Ethers.Transaction.Signed do
     end
 
     defp signature_fields(signed_tx) do
-      [signed_tx.signature_y_parity_or_v, signed_tx.signature_r, signed_tx.signature_s]
+      [
+        signed_tx.signature_y_parity_or_v,
+        remove_leading_zeros(signed_tx.signature_r),
+        remove_leading_zeros(signed_tx.signature_s)
+      ]
     end
   end
 end

lib/ethers/utils.ex

@@ -540,4 +540,11 @@ defmodule Ethers.Utils do
         raise ArgumentError, "Invalid Ethereum address binary #{inspect(address)}"
     end
   end
+
+  @doc """
+  Removes leading zeros from a binary.
+  """
+  @spec remove_leading_zeros(binary()) :: binary()
+  def remove_leading_zeros(<<0, rest::binary>>), do: remove_leading_zeros(rest)
+  def remove_leading_zeros(bin) when is_binary(bin), do: bin
 end