From 42849fb3ec1d0369f8212ba35e3f2e112afbab35 Mon Sep 17 00:00:00 2001 From: Gernot Maier Date: Mon, 26 Jan 2026 12:18:38 +0100 Subject: [PATCH 1/3] bug fix size / dist2 --- docs/changes/41.bugfix.md | 1 + src/eventdisplay_ml/data_processing.py | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 docs/changes/41.bugfix.md diff --git a/docs/changes/41.bugfix.md b/docs/changes/41.bugfix.md new file mode 100644 index 0000000..6d403b8 --- /dev/null +++ b/docs/changes/41.bugfix.md @@ -0,0 +1 @@ +Fix wrong calculation of `size / dist**2` feature, which results always zero values. diff --git a/src/eventdisplay_ml/data_processing.py b/src/eventdisplay_ml/data_processing.py index 05b1ecc..3671f49 100644 --- a/src/eventdisplay_ml/data_processing.py +++ b/src/eventdisplay_ml/data_processing.py @@ -838,8 +838,9 @@ def flatten_telescope_variables(n_tel, flat_features, index, tel_config=None): if f"loss_{i}" in df_flat and f"dist_{i}" in df_flat: new_cols[f"loss_loss_{i}"] = df_flat[f"loss_{i}"] ** 2 new_cols[f"loss_dist_{i}"] = df_flat[f"loss_{i}"] * df_flat[f"dist_{i}"] + if f"size_{i}" in df_flat and f"dist_{i}" in df_flat: + new_cols[f"size_dist2_{i}"] = df_flat[f"size_{i}"] / (df_flat[f"dist_{i}"] ** 2 + 1e-6) if f"width_{i}" in df_flat and f"length_{i}" in df_flat: - new_cols[f"size_dist2_{i}"] = df_flat[f"width_{i}"] / (df_flat[f"length_{i}"] + 1e-6) new_cols[f"width_length_{i}"] = df_flat[f"width_{i}"] / (df_flat[f"length_{i}"] + 1e-6) df_flat = pd.concat([df_flat, pd.DataFrame(new_cols, index=index)], axis=1) From 073d4ee7ca2cdb79aa21c455669894c2ea4b20bd Mon Sep 17 00:00:00 2001 From: Gernot Maier Date: Mon, 26 Jan 2026 12:22:49 +0100 Subject: [PATCH 2/3] Update docs/changes/41.bugfix.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- docs/changes/41.bugfix.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/changes/41.bugfix.md b/docs/changes/41.bugfix.md index 6d403b8..515ce83 100644 --- a/docs/changes/41.bugfix.md +++ b/docs/changes/41.bugfix.md @@ -1 +1 @@ -Fix wrong calculation of `size / dist**2` feature, which results always zero values. +Fix wrong calculation of `size / dist**2` feature, which was previously computed as `width / length` instead of `size / dist**2`. From e511f5145ba99b87a1a270614a66128951622e1f Mon Sep 17 00:00:00 2001 From: Gernot Maier Date: Mon, 26 Jan 2026 12:23:17 +0100 Subject: [PATCH 3/3] correct pr number --- docs/changes/{41.bugfix.md => 44.bugfix.md} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename docs/changes/{41.bugfix.md => 44.bugfix.md} (100%) diff --git a/docs/changes/41.bugfix.md b/docs/changes/44.bugfix.md similarity index 100% rename from docs/changes/41.bugfix.md rename to docs/changes/44.bugfix.md