fix(agent): remove debug code and refactor detached process handling #1568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@copilot also implement changes based on this thread in this PR: #1567 (comment) |
Co-authored-by: pacmancoder <[email protected]>
Copilot
AI
changed the title
[WIP] Address feedback on exec detached mode implementation
fix(agent): remove debug code that hides console windows for all processes
Nov 11, 2025
Copilot finished work on behalf of
pacmancoder
November 11, 2025 13:03
Co-authored-by: pacmancoder <[email protected]>
Contributor
Author
Extracted the duplicated detached mode handling logic into a helper function named Fixed in commit 9010462 |
Copilot
AI
changed the title
fix(agent): remove debug code that hides console windows for all processes
fix(agent): remove debug code and refactor detached process handling
Nov 11, 2025
Copilot finished work on behalf of
pacmancoder
November 11, 2025 13:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes leftover debug code from
prepare_process()that was inadvertently hiding console windows for all processes without IO redirection, not just detached processes.The code set
STARTF_USESHOWWINDOWandSW_HIDEon the startup info, affecting behavioral correctness for existing non-detached process execution.Additionally, refactors duplicated detached mode handling logic into a shared helper function to improve code maintainability.
Changes:
startup_info.dwFlags |= STARTF_USESHOWWINDOWstartup_info.wShowWindow = SW_HIDEassignmentsend_detached_process_success()helper method toMessageProcessorexec_process,exec_batch,exec_winps, andexec_pwshmethodsThe imports remain as they're still correctly used in
prepare_process_with_io_redirection().✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.