-
Notifications
You must be signed in to change notification settings - Fork 23
feat(agent): implement exec detached mode #1567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Let maintainers know that an action is required on their side
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a detached execution mode for the agent's process execution functionality, allowing fire-and-forget process launches without IO redirection or active session management.
Key changes:
- Added
run_detached()method to spawn processes that run independently without IO monitoring - Refactored
WinApiProcessCtxto remove the storedio_notification_txfield, passing it as a parameter instead - Implemented console window hiding for all spawned processes (not just detached ones)
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| devolutions-session/src/dvc/task.rs | Added detached mode handling in four message processors (exec_process, exec_batch, exec_winps, exec_pwsh), checking is_detached() flag and calling run_detached() instead of normal execution flow |
| devolutions-session/src/dvc/process.rs | Refactored WinApiProcessCtx to pass io_notification_tx as parameter; added run_impl() and run_detached() methods; implemented console window hiding via SW_HIDE flag |
| devolutions-session/Cargo.toml | Updated now-proto-pdu dependency to use git branch feat/exec-detached instead of crates.io version |
| Cargo.lock | Updated lockfile with new now-proto-pdu version from git and resolved transitive dependency versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@pacmancoder I've opened a new pull request, #1568, to work on those changes. Once the pull request is ready, I'll request review from you. |
46817c1 to
e535c79
Compare
No description provided.