refactor(SidePanel): optimize form re-initialization logic with memoization

Author: PierreRaybaut

src/App.tsx

@@ -1059,7 +1059,7 @@ export default function App() {
         setBusy(false);
       }
     },
-    [runtime, refreshResults, activePanel],
+    [runtime, refreshResults, activePanel, notify],
   );
 
   const handleAnalysis = useCallback(
@@ -1638,7 +1638,7 @@ export default function App() {
         setBusy(false);
       }
     },
-    [runtime, pendingRoiGrid, refresh],
+    [runtime, pendingRoiGrid, refresh, confirm],
   );
 
   const handleSaveWorkspaceHdf5 = useCallback(async () => {
@@ -1729,7 +1729,7 @@ export default function App() {
       }
     };
     input.click();
-  }, [runtime, refresh, setWorkspaceFilename, markClean]);
+  }, [runtime, refresh, setWorkspaceFilename, markClean, notify]);
 
   const handleImportHdf5 = useCallback(() => {
     // Open the H5 browser dialog with no preloaded file; the user picks
@@ -1766,7 +1766,7 @@ export default function App() {
       setCurrentId(oids[oids.length - 1] ?? null);
       await refresh(oids[oids.length - 1] ?? null);
     },
-    [refresh],
+    [refresh, notify],
   );
 
   const handleSaveFile = useCallback(async () => {
@@ -1817,7 +1817,7 @@ export default function App() {
     a.click();
     document.body.removeChild(a);
     URL.revokeObjectURL(url);
-  }, [runtime, currentId, data, imageData, activePanel]);
+  }, [runtime, currentId, data, imageData, activePanel, notify, prompt]);
 
   /** Open the "Save to directory…" dialog with the current selection
    *  (falls back to the whole panel when nothing is explicitly selected,
@@ -2041,7 +2041,7 @@ export default function App() {
         setBusy(false);
       }
     },
-    [runtime, pendingSaveToDir, activePanel],
+    [runtime, pendingSaveToDir, activePanel, confirm, notify],
   );
 
   const handleOpenFile = useCallback(async () => {
@@ -2256,6 +2256,10 @@ export default function App() {
       toggleAIPanel,
       selectedIds.length,
       currentId,
+      handleDuplicateSelection,
+      handleMoveSelectionDown,
+      handleMoveSelectionUp,
+      handleRenameCurrent,
     ],
   );
 

src/aiassistant/conversationExport.ts

@@ -114,6 +114,7 @@ export function conversationToMarkdown(conv: Conversation): string {
  *  result is a valid filename on Windows / macOS / Linux. */
 export function sanitizeFilename(name: string, maxLen = 80): string {
   const cleaned = name
+    // eslint-disable-next-line no-control-regex -- intentional: strip ASCII control chars from filenames
     .replace(/[\\/:*?"<>|\u0000-\u001f]/g, " ")
     .replace(/\s+/g, " ")
     .trim();

src/components/SidePanel.tsx

@@ -601,6 +601,20 @@ function ProcessingPanel({
     [runtime, oid, onApplied],
   );
 
+  // Key on the canonical applied values (not ``refreshNonce``) so the
+  // form is only re-initialised when the Python-side baseline actually
+  // changes.  ``refreshNonce`` bumps *before* the parent's async
+  // ``getLastProcessing`` re-fetch resolves, so keying on it would
+  // remount the form with the stale ``info.values`` snapshot — making
+  // freshly-typed values appear to revert to the previous baseline
+  // after Apply.
+  // Computed unconditionally to satisfy the rules-of-hooks even when the
+  // early-return branch below is taken.
+  const valuesKey = useMemo(
+    () => JSON.stringify(info.values ?? {}),
+    [info.values],
+  );
+
   // Parameterless features: nothing to edit, just expose a "Re-apply"
   // button so the user can still trigger the recomputation.
   if (!info.has_params || !info.schema) {
@@ -626,17 +640,6 @@ function ProcessingPanel({
       </div>
     );
   }
-  // Key on the canonical applied values (not ``refreshNonce``) so the
-  // form is only re-initialised when the Python-side baseline actually
-  // changes.  ``refreshNonce`` bumps *before* the parent's async
-  // ``getLastProcessing`` re-fetch resolves, so keying on it would
-  // remount the form with the stale ``info.values`` snapshot — making
-  // freshly-typed values appear to revert to the previous baseline
-  // after Apply.
-  const valuesKey = useMemo(
-    () => JSON.stringify(info.values ?? {}),
-    [info.values],
-  );
   return (
     <div className="processing-panel">
       <ProcessingHeader info={info} />