feat: add process tags to profiling #5072
Draft
+32
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… This is still missing memoization and additional tests.
…he payload has the process tag only when the feature is enabled.
…versions so this fixes that.
Co-authored-by: Marco Costa <[email protected]>
…uby conflict with sqlite and it is not needed for this test
… environment variable.
Co-authored-by: Sergey Fedorov <[email protected]>
Co-authored-by: Sergey Fedorov <[email protected]>
…nd to 200 characters
Co-authored-by: Sergey Fedorov <[email protected]>
Co-authored-by: Sergey Fedorov <[email protected]>
…ts are allowed for tag values
… before setting process tags.
Co-authored-by: Oleg Pudeyev <[email protected]>
…e requirement to change the default encoding behavior and adjust tag normalizer variables.
Co-authored-by: Marco Costa <[email protected]>
Co-authored-by: Oleg Pudeyev <[email protected]>
Co-authored-by: Oleg Pudeyev <[email protected]>
… need to add the additional process values normalization logic for service names since they can only be 100 characters and cannot have colons.
Co-authored-by: Oleg Pudeyev <[email protected]>
Co-authored-by: Sergey Fedorov <[email protected]>
… tests for the singular version of MAX_PROCESS_VALUE_BYTE_SIZE
Member
|
Now that #5033 has landed, this probably needs a rebase/merge from master 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements AIDM-254, which is to add process tags to the profiling payloads.
Requires https://github.com/DataDog/libdatadog/pull/1359/files to be implemented first.
Motivation:
AIDM-254
Change log entry
Add process tags to the profiling payloads.
Additional Notes:
When reviewing this, keep in mind that we need the implementations across tracers to be consistent:
Java PR: DataDog/dd-trace-java#8780
Python PR: DataDog/dd-trace-py#15226
.NET PR: DataDog/dd-trace-dotnet#7715
Open Questions:
Also do not merge this PR until #5033 is merged.
Also requires libdatadog: DataDog/libdatadog#1359
How to test the change?