chore: remove references to Python version 3.8 (#15438)

taegyunkim · web-flow · commit ccdae8c9f238 · 2025-12-01T17:27:21.000Z
## Description

&lt;!-- Provide an overview of the change and motivation for the change --&gt;

## Testing

&lt;!-- Describe your testing strategy or note what tests are included --&gt;

## Risks

&lt;!-- Note any risks associated with this change, or "None" if no risks
--&gt;

## Additional Notes

&lt;!-- Any other information that would be helpful for reviewers --&gt;
diff --git a/.github/workflows/changelog.yml b/.github/workflows/changelog.yml
@@ -29,7 +29,7 @@ jobs:
       - uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
         name: Install Python
         with:
-          python-version: '3.8'
+          python-version: '3.13'
 
       - name: Install Dependencies
         run: pip install reno docutils
@@ -40,7 +40,7 @@ jobs:
       - name: Generate changelog
         run: |
           reno report | tee CHANGELOG.rst
-          rst2html.py CHANGELOG.rst CHANGELOG.html
+          rst2html CHANGELOG.rst CHANGELOG.html
 
       - name: Upload CHANGELOG.rst
         uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
diff --git a/.github/workflows/generate-package-versions.yml b/.github/workflows/generate-package-versions.yml
@@ -19,11 +19,6 @@ jobs:
         with:
           persist-credentials: false
 
-      - name: Setup Python 3.8
-        uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
-        with:
-          python-version: "3.8"
-
       - name: Setup Python 3.9
         uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
         with:
diff --git a/.github/workflows/generate-supported-versions.yml b/.github/workflows/generate-supported-versions.yml
@@ -17,11 +17,6 @@ jobs:
         with:
           persist-credentials: false
 
-      - name: Setup Python 3.8
-        uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
-        with:
-          python-version: "3.8"
-
       - name: Setup Python 3.9
         uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
         with:
diff --git a/.github/workflows/requirements-locks.yml b/.github/workflows/requirements-locks.yml
@@ -25,7 +25,7 @@ jobs:
         run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
 
       - name: Set python interpreters
-        run: pyenv global 3.10 3.8 3.9 3.11 3.12 3.13 3.14
+        run: pyenv global 3.10 3.9 3.11 3.12 3.13 3.14
 
       - name: Install Dependencies
         # Keep pip at <25.3 until https://github.com/jazzband/pip-tools/issues/2252 is resolved
diff --git a/ddtrace/appsec/_iast/_taint_tracking/_vendor/pybind11/pybind11/__init__.py b/ddtrace/appsec/_iast/_taint_tracking/_vendor/pybind11/pybind11/__init__.py
@@ -1,11 +1,5 @@
 from __future__ import annotations
 
-import sys
-
-if sys.version_info < (3, 8):  # noqa: UP036
-    msg = "pybind11 does not support Python < 3.8. v2.13 was the last release supporting Python 3.7."
-    raise ImportError(msg)
-
 
 from ._version import __version__, version_info
 from .commands import get_cmake_dir, get_include, get_pkgconfig_dir
diff --git a/lib-injection/sources/sitecustomize.py b/lib-injection/sources/sitecustomize.py
@@ -42,7 +42,7 @@ def parse_version(version):
 SCRIPT_DIR = os.path.dirname(__file__)
 RUNTIMES_ALLOW_LIST = {
     "cpython": {
-        "min": Version(version=(3, 8), constraint=""),
+        "min": Version(version=(3, 9), constraint=""),
         "max": Version(version=(3, 14), constraint=""),
     }
 }
diff --git a/pyproject.toml b/pyproject.toml
@@ -1,7 +1,7 @@
 [build-system]
 requires = [
     "cython",
-    "cmake>=3.24.2,<3.28; python_version>='3.8'",
+    "cmake>=3.24.2,<3.28",
     "setuptools-rust<2",
     "patchelf>=0.17.0.0; sys_platform == 'linux'",
 ]
@@ -22,7 +22,6 @@ classifiers = [
     "Programming Language :: Python :: Implementation :: CPython",
     "Programming Language :: Python",
     "Programming Language :: Python :: 3 :: Only",
-    "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
diff --git a/tests/appsec/iast/_ast/fixtures/annotated_code37.py b/tests/appsec/iast/_ast/fixtures/annotated_code37.py
diff --git a/tests/appsec/iast/_ast/test_ast_patching_type_hints.py b/tests/appsec/iast/_ast/test_ast_patching_type_hints.py
@@ -1,10 +1,7 @@
 # -*- encoding: utf-8 -*-
 from ast import unparse
-import sys
 from typing import Text
 
-import pytest
-
 
 def _get_patched_code(module_path: Text, module_name: Text) -> str:
     """
@@ -30,8 +27,7 @@ def _get_patched_code(module_path: Text, module_name: Text) -> str:
         return new_code
 
 
-@pytest.mark.skipif(sys.version_info == (3, 8, 0), reason="Sample code not compatible with Python 3.8")
-def test_no_index_aspects_py38plus():
+def test_no_index_aspects():
     """
     Methods should not be replaced by the aspect since it's not the builtin method
     """
@@ -43,17 +39,3 @@ def test_no_index_aspects_py38plus():
     # Makes sure all add operators are patched:
     assert "ddtrace_aspects.add_aspect" in patched_code
     assert "+" not in patched_code
-
-
-def test_no_index_aspects_py37():
-    """
-    Methods should not be replaced by the aspect since it's not the builtin method
-    """
-    patched_code = _get_patched_code("tests/appsec/iast/_ast/fixtures/annotated_code37.py", "annotated_code")
-
-    # Makes sure no subscripts are patched:
-    assert "index_aspect" not in patched_code
-
-    # Makes sure all add operators are patched:
-    assert "ddtrace_aspects.add_aspect" in patched_code
-    assert "+" not in patched_code
diff --git a/tests/appsec/iast/taint_sinks/test_code_injection_inspect_regression.py b/tests/appsec/iast/taint_sinks/test_code_injection_inspect_regression.py
@@ -6,7 +6,6 @@
 f_back and other crashes.
 """
 
-import sys
 from unittest import mock
 
 import pytest
@@ -165,7 +164,6 @@ def test_function():
         data = _get_iast_data()
         assert len(data["vulnerabilities"]) == 1
 
-    @pytest.mark.skipif(sys.version_info < (3, 8), reason="Mock spec issues with older Python")
     def test_eval_no_globals_extraction_on_currentframe_none(self, iast_context_defaults):
         """
         Verify that when currentframe returns None, we don't try to access f_back.
diff --git a/tests/appsec/integrations/flask_tests/test_iast_flask_entrypoint_iast_patches.py b/tests/appsec/integrations/flask_tests/test_iast_flask_entrypoint_iast_patches.py
@@ -93,7 +93,6 @@ def _uninstall_watchdog_and_reload():
         del sys.modules["tests.appsec.iast.fixtures.entrypoint.app_main_patched"]
 
 
-@pytest.mark.skipif(sys.version_info < (3, 9, 0), reason="APPSEC-59493: Test not compatible with Python 3.8")
 @pytest.mark.subprocess(err=None)
 def test_ddtrace_iast_flask_no_patch():
     import dis
diff --git a/tests/appsec/integrations/flask_tests/test_iast_flask_testagent.py b/tests/appsec/integrations/flask_tests/test_iast_flask_testagent.py
@@ -1,6 +1,5 @@
 import concurrent.futures
 import json
-import sys
 
 import pytest
 
@@ -520,7 +519,6 @@ def test_gevent_sensitive_socketpair(server, config, iast_enabled, iast_test_tok
         assert response.text == "OK:True"
 
 
-@pytest.mark.skipif(sys.version_info < (3, 9, 0), reason="Test not compatible with Python 3.8")
 @pytest.mark.parametrize("server, config", _GEVENT_SERVERS_SCENARIOS)
 @pytest.mark.parametrize("iast_enabled", ("true", "false"))
 def test_gevent_sensitive_greenlet(server, config, iast_enabled, iast_test_token):
diff --git a/tests/contrib/django/test_django_appsec_snapshots.py b/tests/contrib/django/test_django_appsec_snapshots.py
@@ -2,7 +2,6 @@
 import os
 import re
 import subprocess
-import sys
 
 import django
 import pytest
@@ -57,9 +56,7 @@ def daphne_client(django_asgi, additional_env=None):
         proc.terminate()
 
 
-@pytest.mark.skipif(
-    django.VERSION < (3, 2, 0) or sys.version_info[:2] == (3, 8), reason="Only want to test with latest Django"
-)
+@pytest.mark.skipif(django.VERSION < (3, 2, 0), reason="Only want to test with latest Django")
 @snapshot(
     ignores=[
         "error",
@@ -90,9 +87,7 @@ def test_appsec_enabled():
         assert resp.content == b"Hello, test app."
 
 
-@pytest.mark.skipif(
-    django.VERSION < (3, 2, 0) or sys.version_info[:2] == (3, 8), reason="Only want to test with latest Django"
-)
+@pytest.mark.skipif(django.VERSION < (3, 2, 0), reason="Only want to test with latest Django")
 @snapshot(
     ignores=[
         "error",
@@ -123,9 +118,7 @@ def test_appsec_enabled_attack():
         assert resp.status_code == 404
 
 
-@pytest.mark.skipif(
-    django.VERSION < (3, 2, 0) or sys.version_info[:2] == (3, 8), reason="Only want to test with latest Django"
-)
+@pytest.mark.skipif(django.VERSION < (3, 2, 0), reason="Only want to test with latest Django")
 @snapshot(
     ignores=[
         "error",
@@ -159,9 +152,7 @@ def test_request_ipblock_nomatch_200():
         assert result.content == b"Hello, test app."
 
 
-@pytest.mark.skipif(
-    django.VERSION < (3, 2, 0) or sys.version_info[:2] == (3, 8), reason="Only want to test with latest Django"
-)
+@pytest.mark.skipif(django.VERSION < (3, 2, 0), reason="Only want to test with latest Django")
 @snapshot(
     ignores=[
         "error",
@@ -204,9 +195,7 @@ def test_request_ipblock_match_403():
         assert body_parsed == constants.BLOCKED_RESPONSE_HTML
 
 
-@pytest.mark.skipif(
-    django.VERSION < (3, 2, 0) or sys.version_info[:2] == (3, 8), reason="Only want to test with latest Django"
-)
+@pytest.mark.skipif(django.VERSION < (3, 2, 0), reason="Only want to test with latest Django")
 @snapshot(
     ignores=[
         "error",
diff --git a/tests/profiling/collector/test_threading.py b/tests/profiling/collector/test_threading.py
@@ -158,10 +158,6 @@ def test_user_threads_have_native_id():
 
     from ddtrace.profiling import profiler
 
-    # DEV: We used to run this test with ddtrace_run=True passed into the
-    # subprocess decorator, but that caused this to be flaky for Python 3.8.x
-    # with gevent. When it failed for that specific venv, current_thread()
-    # returned a DummyThread instead of a _MainThread.
     p = profiler.Profiler()
     p.start()
 
diff --git a/tests/profiling/test_code_provenance.py b/tests/profiling/test_code_provenance.py
@@ -2,19 +2,14 @@
 import sys
 import sysconfig
 
+import jsonschema
 import pytest
 
 from ddtrace.internal.datadog.profiling.code_provenance import json_str_to_export
 
 
 PY_VERSION = sys.version_info[:2]
 
-# importing jsonschema in 3.8 results in an error
-#     raise exceptions.NoSuchResource(ref=uri) from None
-# E   referencing.exceptions.NoSuchResource: 'http://json-schema.org/draft-03/schema#'
-if PY_VERSION > (3, 8):
-    import jsonschema  # noqa: E402
-
 
 # Copied from RFC
 SCHEMA = {
@@ -53,12 +48,11 @@
 def is_valid_json(s: str) -> bool:
     try:
         json_obj = json.loads(s)
-        if PY_VERSION > (3, 8):
-            try:
-                jsonschema.validate(json_obj, SCHEMA)
-            except jsonschema.exceptions.ValidationError as e:
-                print(f"Validation error: {e.message}")
-                return False
+        try:
+            jsonschema.validate(json_obj, SCHEMA)
+        except jsonschema.exceptions.ValidationError as e:
+            print(f"Validation error: {e.message}")
+            return False
         return True
     except json.JSONDecodeError:
         print(f"Invalid JSON: {s}")
@@ -71,7 +65,6 @@ def test_outputs_valid_json(self):
         json_str = json_str_to_export()
         assert is_valid_json(json_str)
 
-    @pytest.mark.skipif(PY_VERSION == (3, 8), reason="jsonschema results in an error in 3.8 with ddtrace")
     def test_valid_json_but_invalid_schema(self):
         # Just a sanity check to ensure that jsonschema is working as expected
         json_obj = {
diff --git a/tests/profiling/test_gunicorn.py b/tests/profiling/test_gunicorn.py
@@ -130,10 +130,6 @@ def _test_gunicorn(gunicorn, tmp_path, monkeypatch, *args):
         )
 
 
-@pytest.mark.skipif(
-    sys.version_info[:2] == (3, 8) and os.environ.get("DD_PROFILE_TEST_GEVENT") == "1",
-    reason="Flaky and fails often on Python 3.8 with DD_PROFILE_TEST_GEVENT=1",
-)
 def test_gunicorn(gunicorn, tmp_path, monkeypatch):
     # type: (...) -> None
     args = ("-k", "gevent") if TESTING_GEVENT else tuple()
diff --git a/tests/profiling/test_main.py b/tests/profiling/test_main.py
@@ -26,8 +26,6 @@ def test_call_script():
 
 @pytest.mark.skipif(not os.getenv("DD_PROFILE_TEST_GEVENT", False), reason="Not testing gevent")
 def test_call_script_gevent():
-    if sys.version_info[:2] == (3, 8):
-        pytest.skip("this test is flaky on 3.8 with stack v2")
     env = os.environ.copy()
     env["DD_PROFILING_ENABLED"] = "1"
     stdout, stderr, exitcode, pid = call_program(
diff --git a/tests/profiling/test_profiler.py b/tests/profiling/test_profiler.py
@@ -298,10 +298,6 @@ def test_user_threads_have_native_id():
 
     from ddtrace.profiling import profiler
 
-    # DEV: We used to run this test with ddtrace_run=True passed into the
-    # subprocess decorator, but that caused this to be flaky for Python 3.8.x
-    # with gevent. When it failed for that specific venv, current_thread()
-    # returned a DummyThread instead of a _MainThread.
     p = profiler.Profiler()
     p.start()
 

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ def parse_version(version):`
`42`	`42`	`SCRIPT_DIR = os.path.dirname(__file__)`
`43`	`43`	`RUNTIMES_ALLOW_LIST = {`
`44`	`44`	`"cpython": {`
`45`		`- "min": Version(version=(3, 8), constraint=""),`
	`45`	`+ "min": Version(version=(3, 9), constraint=""),`
`46`	`46`	`"max": Version(version=(3, 14), constraint=""),`
`47`	`47`	`}`
`48`	`48`	`}`