Skip to content

Configuration schema names ${run_path} (the string literal) as a default for run_path. #55426

Description

@webern

Here, the schema defines ${run_path}, the literal string, as the default for the ${run_path}.

This leads to downstream consumer code needing to guard against it with something "handwritten" (or AI written) like this, just in case:

    fn consume_run_path(&mut self, value: String) {
        // In the vendored schema, run_path is defaulted to the placeholder ${run_path}. Though it
        // seems highly unlikely this could slip through to ADP, we check for it, warn and treat
        // the value as unset.
        //
        // Note that for this config, we do not care whether provenance is explicit or default. We
        // just want to know whether we have a value or not.
        if value == "${run_path}" {Collapse commentComment on line R1090thieman commented on Aug 25, 2026 thiemanon Aug 25, 
            warn!("`run_path` contains the unresolved schema placeholder '${{run_path}}'. Treating it as unset.");
            self.config.shared.run_path = None;
        } else if value.is_empty() {
            // ...
        }
    }

Request:

Consider defaulting run_path to null instead. Also consider documenting the various platform-specific defaults in the schema (since JSON schema does not give us platform-specific default resolution).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions