Skip to content

removed sandboxes, patched emphermial sandboxes #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jon3350 merged 1 commit into from
May 10, 2026
Merged

removed sandboxes, patched emphermial sandboxes #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 19 additions & 25 deletions apps/web/src/routes/sandboxes/$sandboxId.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import {
Play,
RefreshCw,
Save,
Square,
Terminal,
} from "lucide-react";
import { motion } from "motion/react";
Expand Down Expand Up @@ -100,18 +99,13 @@ function SandboxDetailContent({ sandbox }: { sandbox: Sandbox }) {
mutationFn: updateSandboxFn,
});
const lifecycle = useMutation({
mutationFn: async (next: "start" | "stop") => {
if (next === "start") {
return sandboxApi.startSandbox(sandbox.daytonaSandboxId);
}
return sandboxApi.stopSandbox(sandbox.daytonaSandboxId);
},
onSuccess: (_, next) => {
mutationFn: () => sandboxApi.startSandbox(sandbox.daytonaSandboxId),
onSuccess: () => {
updateSandboxStatus.mutate({
id: sandbox._id,
status: next === "start" ? "running" : "stopped",
status: "running",
});
toast.success(next === "start" ? "Sandbox started" : "Sandbox stopped");
toast.success("Sandbox started");
},
onError: () => toast.error("Sandbox lifecycle action failed"),
});
Expand Down Expand Up @@ -157,21 +151,21 @@ function SandboxDetailContent({ sandbox }: { sandbox: Sandbox }) {
</div>
</div>
<div className="flex items-center gap-2">
<Button
size="sm"
variant="outline"
onClick={() => lifecycle.mutate(isRunning ? "stop" : "start")}
disabled={lifecycle.isPending}
>
{lifecycle.isPending ? (
<Loader2 size={14} className="animate-spin" />
) : isRunning ? (
<Square size={14} />
) : (
<Play size={14} />
)}
{isRunning ? "Stop" : "Start"}
</Button>
{!isRunning && (
<Button
size="sm"
variant="outline"
onClick={() => lifecycle.mutate()}
disabled={lifecycle.isPending}
>
{lifecycle.isPending ? (
<Loader2 size={14} className="animate-spin" />
) : (
<Play size={14} />
)}
Start
</Button>
)}
<Button
size="sm"
onClick={saveMetadata}
Expand Down
23 changes: 8 additions & 15 deletions apps/web/src/routes/sandboxes/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,21 +352,14 @@ function SandboxCard({
<Edit size={12} />
Edit
</DropdownMenuItem>
<DropdownMenuItem
onClick={() => onToggle(sandbox._id, sandbox.status)}
>
{sandbox.status === "running" ? (
<>
<Square size={12} />
Stop
</>
) : (
<>
<Play size={12} />
Start
</>
)}
</DropdownMenuItem>
{sandbox.status !== "running" && (
<DropdownMenuItem
onClick={() => onToggle(sandbox._id, sandbox.status)}
>
<Play size={12} />
Start
</DropdownMenuItem>
)}
<DropdownMenuSeparator />
<DropdownMenuItem
className="text-destructive"
Expand Down
2 changes: 1 addition & 1 deletion packages/fastapi/app/services/daytona_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ def create_sandbox(
language=language,
auto_stop_interval=15,
labels=sandbox_labels,
ephemeral=ephemeral,
ephemeral=False,
)

logger.info(
Expand Down
Loading