Skip to content

Commit ad5ab68

Browse files
masked sensitive information in logs
1 parent 40e0d22 commit ad5ab68

File tree

4 files changed

+13
-4
lines changed

4 files changed

+13
-4
lines changed

src/authentication/logging/SensitiveDataMasker.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,15 @@ function maskSensitiveData(message) {
1414
return Constants.LOG_REQUEST_AFTER_MLE + maskSensitiveData(message.substring(Constants.LOG_REQUEST_AFTER_MLE.length));
1515
}
1616

17+
if (typeof message === 'string' && message.startsWith(Constants.LOG_RESPONSE_AFTER_MLE)) {
18+
return Constants.LOG_RESPONSE_AFTER_MLE + maskSensitiveData(message.substring(Constants.LOG_RESPONSE_AFTER_MLE.length));
19+
}
20+
if (typeof message === 'string' && message.startsWith(Constants.LOG_RESPONSE_BEFORE_MLE)) {
21+
return Constants.LOG_RESPONSE_BEFORE_MLE + maskSensitiveData(message.substring(Constants.LOG_RESPONSE_BEFORE_MLE.length));
22+
}
23+
1724
if (Utility.isJsonString(message)) {
18-
jsonMsg = JSON.parse(message)
25+
jsonMsg = JSON.parse(message);
1926
} else {
2027
jsonMsg = JSON.parse(JSON.stringify(message));
2128
}

src/authentication/logging/SensitiveDataTags.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,6 @@ exports.getSensitiveDataTags = function () {
3535
tags.push("prefix");
3636
tags.push("bin");
3737
tags.push("encryptedRequest");
38-
38+
tags.push("encryptedResponse");
3939
return tags;
4040
}

src/authentication/util/Constants.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ module.exports = {
4444
END_TRANSACTION : "************************ LOGGING END ************************",
4545
LOG_REQUEST_BEFORE_MLE : "Request before MLE: ",
4646
LOG_REQUEST_AFTER_MLE : "Request after MLE: ",
47+
LOG_RESPONSE_BEFORE_MLE : "Response before MLE decryption: ",
48+
LOG_RESPONSE_AFTER_MLE : "Response after MLE decryption: ",
4749
MERCHANTID : "MERCHANTID",
4850
MERCHANT_KEY_ID : "MERCHANT_KEY_ID",
4951
MERCHANT_SECERT_KEY : "MERCHANT_SECERT_KEY",

src/authentication/util/MLEUtility.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ exports.checkAndDecryptEncryptedResponse = function (responseBody, merchantConfi
7373
}
7474

7575
logger.debug('Response body contains encrypted data, attempting to decrypt');
76-
logger.debug('LOG_NETWORK_RESPONSE_BEFORE_MLE_DECRYPTION: ' + JSON.stringify(responseBody));
76+
logger.debug(Constants.LOG_RESPONSE_BEFORE_MLE + JSON.stringify(responseBody));
7777

7878
try {
7979
// Private key from config will take precedence over file path.
@@ -90,7 +90,7 @@ exports.checkAndDecryptEncryptedResponse = function (responseBody, merchantConfi
9090

9191
return JWEUtility.decryptJWEUsingPrivateKey(privateKey, responseBody.encryptedResponse)
9292
.then(decryptedData => {
93-
logger.debug('LOG_NETWORK_RESPONSE_AFTER_MLE_DECRYPTION: ' + JSON.stringify(decryptedData));
93+
logger.debug(Constants.LOG_RESPONSE_AFTER_MLE + JSON.stringify(decryptedData));
9494
return JSON.parse(decryptedData);
9595
})
9696
.catch(error => {

0 commit comments

Comments
 (0)