Skip to content

Commit aa3f6b3

Browse files
ryaukwanclaude
andauthored
refactor: remove @material-ui/icons@4 in favor of @mui/icons-material@5 (#179)
* refactor: remove @material-ui/icons@4 in favor of @mui/icons-material@5 All icon imports were already using @mui/icons-material, so this removes the unused @material-ui/icons@4 dependency. Updated .npmrc comment to reflect the remaining peer conflict (due to @mui/styles@5 requiring @types/react@^17.0.0). Closes #175 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: clarify legacy-peer-deps comment to include react peer conflict @mui/styles@5 requires both react@^17.0.0 and @types/react@^17.0.0, not just the types package. Update comment to avoid the impression that fixing the type definitions alone would allow removing the flag. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: apply Copilot suggestion for legacy-peer-deps comment Spell out the exact package version and both peer deps (react and @types/react) for clarity, per Copilot review on PR #179. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 48267fb commit aa3f6b3

3 files changed

Lines changed: 1 addition & 34 deletions

File tree

.npmrc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
1-
# Required until @material-ui/icons@4 is migrated to @mui/icons-material@5 (see issue #175).
2-
# @material-ui/icons@4 has an unresolved peer dependency conflict with React 18.
1+
# Required because @mui/styles@5.10.10 declares peer dependencies on react@^17.0.0 and @types/react@^17.0.0, while the project uses React 18 and @types/react@^18.0.0.
32
legacy-peer-deps=true

package-lock.json

Lines changed: 0 additions & 31 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
"dependencies": {
1313
"@emotion/react": "^11.10.5",
1414
"@emotion/styled": "^11.10.5",
15-
"@material-ui/icons": "^4.11.3",
1615
"@mui/icons-material": "^5.10.9",
1716
"@mui/material": "^5.10.13",
1817
"@mui/styles": "^5.10.10",

0 commit comments

Comments
 (0)