Go test updates

Author: tjmoore4

internal/controller/pgupgrade/jobs_test.go

@@ -165,7 +165,6 @@ kind: Job
 metadata:
   annotations:
     kubectl.kubernetes.io/default-container: database
-  creationTimestamp: null
   labels:
     postgres-operator.crunchydata.com/cluster: pg5
     postgres-operator.crunchydata.com/pgupgrade: pgu2
@@ -186,7 +185,6 @@ spec:
     metadata:
       annotations:
         kubectl.kubernetes.io/default-container: database
-      creationTimestamp: null
       labels:
         postgres-operator.crunchydata.com/cluster: pg5
         postgres-operator.crunchydata.com/pgupgrade: pgu2
@@ -322,7 +320,6 @@ kind: Job
 metadata:
   annotations:
     kubectl.kubernetes.io/default-container: database
-  creationTimestamp: null
   labels:
     postgres-operator.crunchydata.com/cluster: pg5
     postgres-operator.crunchydata.com/pgupgrade: pgu2
@@ -342,7 +339,6 @@ spec:
     metadata:
       annotations:
         kubectl.kubernetes.io/default-container: database
-      creationTimestamp: null
       labels:
         postgres-operator.crunchydata.com/cluster: pg5
         postgres-operator.crunchydata.com/pgupgrade: pgu2

internal/controller/postgrescluster/cluster_test.go

@@ -570,7 +570,6 @@ apiVersion: v1
 kind: Service
 		`))
 		assert.Assert(t, cmp.MarshalMatches(service.ObjectMeta, `
-creationTimestamp: null
 labels:
   postgres-operator.crunchydata.com/cluster: pg5
   postgres-operator.crunchydata.com/role: primary
@@ -599,7 +598,6 @@ ownerReferences:
 apiVersion: v1
 kind: Endpoints
 metadata:
-  creationTimestamp: null
   labels:
     postgres-operator.crunchydata.com/cluster: pg5
     postgres-operator.crunchydata.com/role: primary
@@ -686,7 +684,7 @@ apiVersion: v1
 kind: Service
 		`))
 		assert.Assert(t, cmp.MarshalMatches(service.ObjectMeta, `
-creationTimestamp: null
+
 labels:
   postgres-operator.crunchydata.com/cluster: pg2
   postgres-operator.crunchydata.com/role: replica

internal/controller/postgrescluster/patroni_test.go

@@ -47,7 +47,7 @@ apiVersion: v1
 kind: Service
 		`))
 		assert.Assert(t, cmp.MarshalMatches(service.ObjectMeta, `
-creationTimestamp: null
+
 labels:
   postgres-operator.crunchydata.com/cluster: pg2
   postgres-operator.crunchydata.com/patroni: pg2-ha

internal/controller/postgrescluster/pgadmin_test.go

@@ -67,7 +67,7 @@ apiVersion: v1
 kind: ConfigMap
 		`))
 		assert.Assert(t, cmp.MarshalMatches(configmap.ObjectMeta, `
-creationTimestamp: null
+
 labels:
   postgres-operator.crunchydata.com/cluster: pg1
   postgres-operator.crunchydata.com/role: pgadmin
@@ -135,7 +135,7 @@ func TestGeneratePGAdminService(t *testing.T) {
 			assert.Assert(t, !specified)
 
 			assert.Assert(t, cmp.MarshalMatches(service.ObjectMeta, `
-creationTimestamp: null
+
 name: my-cluster-pgadmin
 namespace: my-ns
 			`))
@@ -152,7 +152,7 @@ apiVersion: v1
 kind: Service
 		`))
 		assert.Assert(t, cmp.MarshalMatches(service.ObjectMeta, `
-creationTimestamp: null
+
 labels:
   postgres-operator.crunchydata.com/cluster: my-cluster
   postgres-operator.crunchydata.com/role: pgadmin
@@ -501,7 +501,6 @@ func TestReconcilePGAdminStatefulSet(t *testing.T) {
 		assert.Assert(t, cmp.MarshalMatches(template.ObjectMeta, `
 annotations:
   kubectl.kubernetes.io/default-container: pgadmin
-creationTimestamp: null
 labels:
   postgres-operator.crunchydata.com/cluster: test-cluster
   postgres-operator.crunchydata.com/data: pgadmin
@@ -615,7 +614,6 @@ terminationGracePeriodSeconds: 30
 annotations:
   annotation1: annotationvalue
   kubectl.kubernetes.io/default-container: pgadmin
-creationTimestamp: null
 labels:
   label1: labelvalue
   postgres-operator.crunchydata.com/cluster: custom-cluster

internal/controller/postgrescluster/pgbouncer_test.go

@@ -47,7 +47,7 @@ func TestGeneratePGBouncerService(t *testing.T) {
 			assert.Assert(t, !specified)
 
 			assert.Assert(t, cmp.MarshalMatches(service.ObjectMeta, `
-creationTimestamp: null
+
 name: pg7-pgbouncer
 namespace: ns5
 			`))
@@ -66,7 +66,7 @@ apiVersion: v1
 kind: Service
 		`))
 		assert.Assert(t, cmp.MarshalMatches(service.ObjectMeta, `
-creationTimestamp: null
+
 labels:
   postgres-operator.crunchydata.com/cluster: pg7
   postgres-operator.crunchydata.com/role: pgbouncer
@@ -383,7 +383,7 @@ func TestGeneratePGBouncerDeployment(t *testing.T) {
 			assert.Assert(t, !specified)
 
 			assert.Assert(t, cmp.MarshalMatches(deploy.ObjectMeta, `
-creationTimestamp: null
+
 name: test-cluster-pgbouncer
 namespace: ns3
 			`))

internal/controller/standalone_pgadmin/configmap_test.go

@@ -213,7 +213,7 @@ apiVersion: v1
 kind: ConfigMap
 		`))
 		assert.Assert(t, cmp.MarshalMatches(configmap.ObjectMeta, `
-creationTimestamp: null
+
 labels:
   postgres-operator.crunchydata.com/pgadmin: pg1
   postgres-operator.crunchydata.com/role: pgadmin

internal/controller/standalone_pgadmin/service_test.go

@@ -39,7 +39,6 @@ kind: Service
 	assert.Assert(t, cmp.MarshalMatches(service.ObjectMeta, `
 annotations:
   test-annotation: test-annotation-val
-creationTimestamp: null
 labels:
   postgres-operator.crunchydata.com/pgadmin: daisy
   postgres-operator.crunchydata.com/role: pgadmin

internal/controller/standalone_pgadmin/statefulset_test.go

@@ -84,7 +84,6 @@ func TestReconcilePGAdminStatefulSet(t *testing.T) {
 		assert.Assert(t, cmp.MarshalMatches(template.ObjectMeta, `
 annotations:
   kubectl.kubernetes.io/default-container: pgadmin
-creationTimestamp: null
 labels:
   postgres-operator.crunchydata.com/data: pgadmin
   postgres-operator.crunchydata.com/pgadmin: test-standalone-pgadmin
@@ -189,7 +188,6 @@ terminationGracePeriodSeconds: 30
 annotations:
   annotation1: annotationvalue
   kubectl.kubernetes.io/default-container: pgadmin
-creationTimestamp: null
 labels:
   label1: labelvalue
   postgres-operator.crunchydata.com/data: pgadmin

internal/postgres/reconcile_test.go

@@ -743,14 +743,10 @@ volumes:
   name: postgres-temp
 `), "expected temp mount in %q container", pod.Spec.Containers[0].Name)
 
-		// NOTE: `creationTimestamp: null` appears in the resulting pod,
-		// but it does not affect the PVC or reconciliation events;
-		// possibly https://pr.k8s.io/100032
 		assert.Assert(t, cmp.MarshalContains(pod.Spec.Volumes, `
 - ephemeral:
     volumeClaimTemplate:
-      metadata:
-        creationTimestamp: null
+      metadata: {}
       spec:
         resources:
           requests:
@@ -773,7 +769,6 @@ volumes:
       metadata:
         annotations:
           n1: etc
-        creationTimestamp: null
         labels:
           gg: asdf
       spec: