[12.0.0-alpha.2: web-sdk: AccountTransactionV0.serializeBlockItem]

[Torakushi]

Bug Description

there is an inconsistency between the old AccountTransaction Behavior and the new AccountTransactionV0

Before, when serializing an AccountTransaction for submission, we used serializeAccountTransactionForSubmission.

Now AccountTransactionV0 has serializeBlockItem which should "Serializes a version 0 account transaction as a block item for submission to the chain."

But the AccountTransactionV0 doesn't includes the encoded version like in AccountTransaction

      const t = '0x' + Buffer.from(AccountTransactionV0.serializeBlockItem(tx)).toString('hex')
     [......]
      const buf = Buffer.from(t, 'hex');
      console.log(deserializeTransaction(new Uint8Array(buf).buffer))

should work

Versions

12.0.0-alpha.2

[soerenbf]

Yes, that function is actually incorrectly defined. The version-byte is only used in inter-node communication, but not when submitting block items to chain.

This function will be deprecated and the correct function will be implemented with #615

[soerenbf]

But the AccountTransactionV0 doesn't includes the encoded version like in AccountTransaction

      const t = '0x' + Buffer.from(AccountTransactionV0.serializeBlockItem(tx)).toString('hex')
     [......]
      const buf = Buffer.from(t, 'hex');
      console.log(deserializeTransaction(new Uint8Array(buf).buffer))

should work

Versions

12.0.0-alpha.2

const t = '00' + Buffer.from(AccountTransactionV0.serializeBlockItem(tx)).toString('hex')
[......]
const buf = Buffer.from(t, 'hex');
console.log(deserializeTransaction(new Uint8Array(buf).buffer))

should work I think, 0x is not valid hex.

Anyway #615 will fix this.

[Torakushi]

Yes it will work (that's what I am doing currently). I didn't want to manually add the encoded version 00. It was just to be consistent with the previous XXXForSubmission functions.
But like you said, it will be fixed by this