Skip to content

Commit 6b9676b

Browse files
committed
chore: Remove migration plan doc
1 parent d8a8533 commit 6b9676b

File tree

6 files changed

+24
-211
lines changed

6 files changed

+24
-211
lines changed

docs/JOBS_API_MIGRATION_PLAN.md

Lines changed: 0 additions & 201 deletions
This file was deleted.

src/composables/queue/useJobMenu.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,10 @@ import { useCopyToClipboard } from '@/composables/useCopyToClipboard'
66
import { st, t } from '@/i18n'
77
import { mapTaskOutputToAssetItem } from '@/platform/assets/composables/media/assetMappers'
88
import { useMediaAssetActions } from '@/platform/assets/composables/useMediaAssetActions'
9-
import { extractWorkflow, fetchJobDetail } from '@/platform/remote/comfyui/jobs/fetchJobs'
9+
import {
10+
extractWorkflow,
11+
fetchJobDetail
12+
} from '@/platform/remote/comfyui/jobs/fetchJobs'
1013
import { useSettingStore } from '@/platform/settings/settingStore'
1114
import type { ComfyWorkflowJSON } from '@/platform/workflow/validation/schemas/workflowSchema'
1215
import { useWorkflowService } from '@/platform/workflow/core/services/workflowService'
@@ -57,7 +60,7 @@ export function useJobMenu(
5760
jobId: string
5861
): Promise<ComfyWorkflowJSON | undefined> => {
5962
const jobDetail = await fetchJobDetail((url) => api.fetchApi(url), jobId)
60-
return extractWorkflow(jobDetail)
63+
return extractWorkflow(jobDetail) as ComfyWorkflowJSON | undefined
6164
}
6265

6366
const openJobWorkflow = async () => {

src/platform/remote/comfyui/history/reconciliation.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* Reconciles server jobs with client-cached jobs for efficient updates.
66
* Uses job ID-based merging with create_time for sort order.
77
*/
8-
import type { JobListItem } from '../jobs/types/jobTypes'
8+
import type { JobListItem } from '../jobs/jobTypes'
99

1010
/**
1111
* Reconciles server jobs with client-cached jobs.

src/scripts/api.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,10 @@ import type { ComfyNodeDef } from '@/schemas/nodeDefSchema'
4545
import type { useFirebaseAuthStore } from '@/stores/firebaseAuthStore'
4646
import type { AuthHeader } from '@/types/authTypes'
4747
import type { NodeExecutionId } from '@/types/nodeIdentification'
48-
import { fetchHistory, fetchQueue } from '@/platform/remote/comfyui/jobs/fetchJobs'
48+
import {
49+
fetchHistory,
50+
fetchQueue
51+
} from '@/platform/remote/comfyui/jobs/fetchJobs'
4952

5053
interface QueuePromptRequestBody {
5154
client_id: string

src/stores/queueStore.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@ import { defineStore } from 'pinia'
33
import { computed, ref, shallowRef, toRaw, toValue } from 'vue'
44

55
import { reconcileJobs } from '@/platform/remote/comfyui/history/reconciliation'
6-
import { extractWorkflow, fetchJobDetail } from '@/platform/remote/comfyui/jobs/fetchJobs'
6+
import {
7+
extractWorkflow,
8+
fetchJobDetail
9+
} from '@/platform/remote/comfyui/jobs/fetchJobs'
710
import type { JobListItem } from '@/platform/remote/comfyui/jobs/jobTypes'
811
import type { NodeId } from '@/platform/workflow/validation/schemas/workflowSchema'
912
import type {
@@ -294,7 +297,7 @@ export class TaskItemImpl {
294297
}
295298

296299
get outputsCount(): number | undefined {
297-
return this.job.outputs_count
300+
return this.job.outputs_count ?? undefined
298301
}
299302

300303
/**
@@ -434,7 +437,9 @@ export class TaskItemImpl {
434437
return
435438
}
436439

437-
await app.loadGraphData(toRaw(workflowData))
440+
await app.loadGraphData(
441+
toRaw(workflowData) as Parameters<typeof app.loadGraphData>[0]
442+
)
438443

439444
// Use full outputs from job detail, or fall back to existing outputs
440445
const outputsToLoad = jobDetail?.outputs ?? this.outputs

tests-ui/tests/stores/queueStore.loadWorkflow.test.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
import { createPinia, setActivePinia } from 'pinia'
22
import { beforeEach, describe, expect, it, vi } from 'vitest'
33

4-
import type { JobListItem } from '@/platform/remote/comfyui/jobs/jobTypes'
4+
import type {
5+
JobDetail,
6+
JobListItem
7+
} from '@/platform/remote/comfyui/jobs/jobTypes'
58
import type { ComfyWorkflowJSON } from '@/platform/workflow/validation/schemas/workflowSchema'
69
import type { ComfyApp } from '@/scripts/app'
710
import { TaskItemImpl } from '@/stores/queueStore'
@@ -88,7 +91,7 @@ describe('TaskItemImpl.loadWorkflow - workflow fetching', () => {
8891
const task = new TaskItemImpl(job)
8992

9093
vi.spyOn(jobsModule, 'fetchJobDetail').mockResolvedValue(
91-
mockJobDetail as jobsModule.JobDetail
94+
mockJobDetail as JobDetail
9295
)
9396

9497
await task.loadWorkflow(mockApp)
@@ -117,7 +120,7 @@ describe('TaskItemImpl.loadWorkflow - workflow fetching', () => {
117120
const runningTask = new TaskItemImpl(job)
118121

119122
vi.spyOn(jobsModule, 'fetchJobDetail').mockResolvedValue(
120-
mockJobDetail as jobsModule.JobDetail
123+
mockJobDetail as JobDetail
121124
)
122125

123126
await runningTask.loadWorkflow(mockApp)

0 commit comments

Comments
 (0)