Skip to content

Commit c0cd924

Browse files
denelonCopilotTrenlyDemitrius Nelon
authored
Standardize PR template with emoji sections and issue types (microsoft#368336)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Kaleb Luedtke <trenlymc@gmail.com> Co-authored-by: Demitrius Nelon <Demitrius.Nelon@microsoft.com>
1 parent b7da23b commit c0cd924

2 files changed

Lines changed: 27 additions & 21 deletions

File tree

‎.github/PULL_REQUEST_TEMPLATE.md‎

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,22 @@
1-
Checklist for Pull Requests
2-
- [ ] Have you signed the [Contributor License Agreement](https://cla.opensource.microsoft.com/microsoft/winget-pkgs)?
3-
- [ ] Is there a linked Issue? If so, fill in the Issue number below.
4-
<!-- Example: Resolves #328283 -->
1+
<!-- PR Title Format: "New package: Publisher.Name version X.Y.Z" or "Update: Publisher.Name to X.Y.Z" -->
2+
3+
## 📖 Description
4+
<!-- Describe what this PR changes. For manifest submissions, include the package name and version. -->
5+
6+
## ✅ Checklist
7+
<!-- Place an "x" between the brackets to check an item. e.g: [x] -->
8+
9+
- [ ] Signed the [Contributor License Agreement](https://cla.opensource.microsoft.com)
10+
- [ ] Linked to an issue (if applicable)
11+
<!-- Example: Resolves #328283 -->
512
- Resolves #[Issue Number]
613

7-
Manifests
8-
- [ ] Have you checked that there aren't other open [pull requests](https://github.com/microsoft/winget-pkgs/pulls) for the same manifest update/change?
9-
- [ ] This PR only modifies one (1) manifest
10-
- [ ] Have you [validated](https://github.com/microsoft/winget-pkgs/blob/master/doc/Authoring.md#validation) your manifest locally with `winget validate --manifest <path>`?
11-
- [ ] Have you tested your manifest locally with `winget install --manifest <path>`?
12-
- [ ] Does your manifest conform to the [1.12 schema](https://github.com/microsoft/winget-pkgs/tree/master/doc/manifest/schema/1.12.0)?
14+
## 📦 Manifest Checklist
1315

14-
Note: `<path>` is the directory's name containing the manifest you're submitting.
16+
- [ ] Checked that there aren't other open [pull requests](https://github.com/microsoft/winget-pkgs/pulls) for the same manifest update/change
17+
- [ ] This PR only modifies one (1) manifest
18+
- [ ] Validated manifest locally with `winget validate --manifest <path>` ([validation guide](https://github.com/microsoft/winget-pkgs/blob/master/doc/ValidationFailureGuide.md))
19+
- [ ] Tested manifest locally with `winget install --manifest <path>`
20+
- [ ] Manifest conforms to the [1.12 schema](https://github.com/microsoft/winget-pkgs/tree/master/doc/manifest/schema/1.12.0)
1521

16-
---
22+
> **Note:** `<path>` is the directory containing the manifest you're submitting.

‎Tools/YamlCreate.ps1‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ if ($Settings) {
236236
exit
237237
}
238238

239-
$ScriptHeader = '# Created with YamlCreate.ps1 v2.7.1'
239+
$ScriptHeader = '# Created with YamlCreate.ps1 v2.7.2'
240240
$ManifestVersion = '1.12.0'
241241
$PSDefaultParameterValues = @{ '*:Encoding' = 'UTF8' }
242242
$Utf8NoBomEncoding = New-Object System.Text.UTF8Encoding $False
@@ -1981,8 +1981,8 @@ Function Read-PRBody {
19811981
# | Where-Object { $_ -like '-*[ ]*' }))
19821982
if ($_line -like '-*[ ]*' ) {
19831983
$_showMenu = $true
1984-
switch -Wildcard ( $_line ) {
1985-
'*CLA*' {
1984+
switch -Regex ( $_line ) {
1985+
'(?i)CLA' {
19861986
if ($ScriptSettings.SignedCLA -eq 'true') {
19871987
$PrBodyContent = $PrBodyContent.Replace($_line, $_line.Replace('[ ]', '[x]'))
19881988
$_showMenu = $false
@@ -1997,7 +1997,7 @@ Function Read-PRBody {
19971997
}
19981998
}
19991999

2000-
'*open `[pull requests`]*' {
2000+
'(?i)open \[pull requests\]' {
20012001
$_menu = @{
20022002
Prompt = "Have you checked that there aren't other open pull requests for the same manifest update/change?"
20032003
Entries = @('[Y] Yes'; '*[N] No')
@@ -2007,7 +2007,7 @@ Function Read-PRBody {
20072007
}
20082008
}
20092009

2010-
'*winget validate*' {
2010+
'(?i)winget validate' {
20112011
if ($? -and $(Get-Command 'winget' -ErrorAction SilentlyContinue)) {
20122012
$PrBodyContent = $PrBodyContent.Replace($_line, $_line.Replace('[ ]', '[x]'))
20132013
$_showMenu = $false
@@ -2024,7 +2024,7 @@ Function Read-PRBody {
20242024
}
20252025
}
20262026

2027-
'*tested your manifest*' {
2027+
'(?i)tested .* ?manifest' {
20282028
if ($script:SandboxTest -eq '0') {
20292029
$PrBodyContent = $PrBodyContent.Replace($_line, $_line.Replace('[ ]', '[x]'))
20302030
$_showMenu = $false
@@ -2041,7 +2041,7 @@ Function Read-PRBody {
20412041
}
20422042
}
20432043

2044-
'*schema*' {
2044+
'(?i)schema' {
20452045
if ($script:Option -ne 'RemoveManifest') {
20462046
$_Match = ($_line | Select-String -Pattern 'https://+.+(?=\))').Matches.Value
20472047
$_menu = @{
@@ -2056,12 +2056,12 @@ Function Read-PRBody {
20562056
}
20572057
}
20582058

2059-
'*only modifies one*' {
2059+
'(?i)(only)? modifies one' {
20602060
$PrBodyContent = $PrBodyContent.Replace($_line, $_line.Replace('[ ]', '[x]'))
20612061
$_showMenu = $false
20622062
}
20632063

2064-
'*linked issue*' {
2064+
'(?i)linked .* ?issue' {
20652065
# Linked issues is handled as a separate prompt below so that the issue numbers can be gathered
20662066
$_showMenu = $false
20672067
}

0 commit comments

Comments
 (0)