Skip to content

Commit bcaa936

Browse files
committed
Refactor: Remove dead collapse code and improve function naming
- Rename updateCollapsedState() to updatePaneVisibility() - Remove unused collapse logic and isCollapsed checks - Simplify pane visibility logic to only handle diagram/code toggle - Improve code maintainability by removing dead code paths The collapse functionality was removed, making the collapse-related logic unnecessary. This cleanup makes the code more readable and focused on its actual purpose.
1 parent 16e748b commit bcaa936

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

src/contentScript/index.ts

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -429,7 +429,7 @@ function ensureContainer(pre: HTMLElement): BlockRegistryEntry {
429429
codeToggle.setAttribute('aria-pressed', view === 'code' ? 'true' : 'false')
430430
updateButtonAppearance(diagramToggle)
431431
updateButtonAppearance(codeToggle)
432-
updateCollapsedState(container)
432+
updatePaneVisibility(container)
433433
}
434434

435435
entry.setView = applyView
@@ -449,24 +449,20 @@ function ensureContainer(pre: HTMLElement): BlockRegistryEntry {
449449
return entry
450450
}
451451

452-
function updateCollapsedState(container: HTMLElement) {
453-
const isCollapsed = container.dataset['collapsed'] === 'true'
452+
function updatePaneVisibility(container: HTMLElement) {
454453
const body = container.querySelector('[data-coderchart-body="true"]') as HTMLElement | null
455454
if (!body) return
456-
body.style.display = isCollapsed ? 'none' : 'block'
455+
body.style.display = 'block'
457456

458457
const view = (container.dataset['view'] as 'diagram' | 'code') || 'diagram'
459458
const diagramHost = body.querySelector('[data-coderchart-pane="diagram"]') as HTMLElement | null
460459
const codeHost = body.querySelector('[data-coderchart-pane="code"]') as HTMLElement | null
461460

462-
const showDiagram = !isCollapsed && view === 'diagram'
463-
const showCode = !isCollapsed && view === 'code'
464-
465461
if (diagramHost) {
466-
diagramHost.style.display = showDiagram ? 'block' : 'none'
462+
diagramHost.style.display = view === 'diagram' ? 'block' : 'none'
467463
}
468464
if (codeHost) {
469-
codeHost.style.display = showCode ? 'block' : 'none'
465+
codeHost.style.display = view === 'code' ? 'block' : 'none'
470466
}
471467
}
472468

0 commit comments

Comments
 (0)