Skip to content

Conversation

@GustavoJST
Copy link
Contributor

Description of the change

Adds support for priorityClassName in Nginx chart

Benefits

If configured, Nginx pods will be able to preempt other less prioritized pods (depending on the preemptionPolicy)

Possible drawbacks

None

Applicable issues

None

Additional information

Currently I use this chart to deploy Nginx instances that act as a loadbalancer for metrics and logs from multiple clusters to a Loki/Mimir instance. Having priorityClassName support for the chart would give me more reassurance that the pod won't be stuck in a pending state due to pod pressure.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md
  • Title of the pull request follows this pattern [<name_of_the_chart>] Descriptive title

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2025

⚠️ Unsigned Commits Detected

This pull request contains unsigned commits.

What does this mean?

Signed commits help ensure the authenticity and traceability of contributions. They allow us to verify that commits actually came from the stated author, even if GitHub accounts are deleted or modified in the future.

Current Policy (Grace Period)

This is currently a warning only. We are in a transition period to give all contributors time to set up commit signing.

After this grace period, all commits will be required to be signed before PRs can be merged.

How to sign your commits

Please see our Contributing Guide for detailed instructions on setting up commit signing.

Resources


This check will become mandatory in the future. Please start signing your commits now to avoid issues later.

Copy link
Member

@zOnlyKroks zOnlyKroks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your contribution

@zOnlyKroks zOnlyKroks merged commit e77747f into CloudPirates-io:main Nov 2, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants