Skip to content

Commit fadb32d

Browse files
authored
Merge pull request #8 from CompatHelper
CompatHelper: bump compat for Optim to 2, (keep existing compat)
2 parents a42cc93 + 030121c commit fadb32d

3 files changed

Lines changed: 14 additions & 11 deletions

File tree

Project.toml

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ JLD2 = "033835bb-8acc-5ee8-8aae-3f567f8a3819"
1414
KernelDensity = "5ab0869b-81aa-558d-bb23-cbf5423bbe9b"
1515
Libdl = "8f399da3-3557-5675-b5ff-fb832c97cbdb"
1616
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
17+
NLSolversBase = "d41bc354-129a-5804-8e4c-c37616107c6c"
1718
Optim = "429524aa-4258-5aef-a3af-852621145aeb"
1819
OrdinaryDiffEq = "1dea7af3-3e70-54e6-95c3-0bf5283fa5ed"
1920
PyCall = "438e738f-606a-5dbb-bf0a-cddfbfd45ab0"
@@ -26,27 +27,28 @@ Unitful = "1986cc42-f94f-5a68-af5c-568840ba703d"
2627

2728
[compat]
2829
Aqua = "^0.8.0"
29-
Chemfiles = "0.10.42"
30+
Chemfiles = "~0.10.42"
3031
Clustering = "0.15.8"
3132
DataFrames = "^1.7.0"
3233
Distances = "0.10.12"
33-
Distributions = "0.25.119"
34+
Distributions = "~0.25.119"
3435
FFTW = "^1.9.0"
35-
FiniteDiff = "2.27.0"
36+
FiniteDiff = "^2.27.0"
3637
JLD2 = "0.5.12, 0.6"
37-
KernelDensity = "0.6.9"
38+
KernelDensity = "~0.6.9"
3839
Libdl = "^1.11.0"
3940
LinearAlgebra = "^1.11.0"
40-
Optim = "^1.12.0"
41+
NLSolversBase = "8"
42+
Optim = "2.0.0"
4143
OrdinaryDiffEq = "^6.93.0"
4244
PyCall = "1.96.4"
4345
Reexport = "1.2.2"
4446
Serialization = "1.11.0"
45-
StaticArrays = "1.9.13"
47+
StaticArrays = "^1.9.13"
4648
Statistics = "1.11.1"
4749
TOML = "1.0.3"
4850
Test = "^1.11.0"
49-
Unitful = "1.24.0"
51+
Unitful = "^1.24.0"
5052
julia = "^1.9.0"
5153

5254
[extras]

src/YetAnotherSimulationSuite.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ module YetAnotherSimulationSuite
2525
using Distributions
2626
using KernelDensity
2727
using OrdinaryDiffEq
28+
using NLSolversBase
2829

2930
import FiniteDiff: JacobianCache, finite_difference_jacobian!
3031

src/analysis/optimizations.jl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ Optimize the geometry of a set of atoms.
151151
"""
152152
function opt(calc::MyCalc, algo, bdys::Vector{MyAtoms}; kwargs...)
153153
x0, vars = prep4pot(calc.b, bdys)
154-
optFunc = Optim.only_fg!((F,G,x) -> fg!(F,G,x, vars, calc))
154+
optFunc = NLSolversBase.only_fg!((F,G,x) -> fg!(F,G,x, vars, calc))
155155
convCrit = Optim.Options(; kwargs...)
156156
res = optimize(optFunc, x0, algo, convCrit)
157157
optBdys = getNewBdys(bdys, res)
@@ -175,7 +175,7 @@ Optimize the geometry of a cell.
175175
"""
176176
function opt(calc::MyCalc, algo, cell::MyCell; kwargs...)
177177
x0, vars = prep4pot(calc.b, cell)
178-
optFunc = Optim.only_fg!((F,G,x) -> fg!(F,G,x, vars, calc))
178+
optFunc = NLSolversBase.only_fg!((F,G,x) -> fg!(F,G,x, vars, calc))
179179
convCrit = Optim.Options(; kwargs...)
180180
res = optimize(optFunc, x0, algo, convCrit)
181181
spos = getScaledPos(res.minimizer, cell.lattice)
@@ -250,7 +250,7 @@ function hiddenOpt(calc::MyCalc, algo, cell, T; kwargs...)
250250
T
251251
)
252252

253-
optFunc = Optim.only_fg!((F,G,x) -> hiddenEoM(F,G,Γ,calc,hideVars,x))
253+
optFunc = NLSolversBase.only_fg!((F,G,x) -> hiddenEoM(F,G,Γ,calc,hideVars,x))
254254
convCrit = Optim.Options(; kwargs...)
255255
res = optimize(optFunc, x0, algo, convCrit)
256256
spos = getScaledPos(res.minimizer, cell.lattice)
@@ -321,7 +321,7 @@ function optCell(calc::MyCalc, algo, cell::MyCell; precon=nothing, kwargs...)
321321
ret = deepcopy(cell)
322322
diag = isdiag(ret.lattice)
323323
lat0 = reshape(ret.lattice, 9) |> Vector
324-
optFunc = Optim.only_fg!(
324+
optFunc = NLSolversBase.only_fg!(
325325
(F,G,x) -> st!(F,G,x, ret, calc; precon=precon, diag=diag)
326326
)
327327
convCrit = Optim.Options(; kwargs...)

0 commit comments

Comments
 (0)