fix: Replace Warning footer bold text with emoji

Author: TsekNet

internal/output/markdown.go

@@ -33,8 +33,13 @@ func writeMarker(sb *strings.Builder, marker string) {
 	}
 }
 
-func countResourceChanges(rd diff.ResourceDiff) (added, modified, deleted int) {
-	return len(rd.Added), len(rd.Modified), len(rd.Deleted)
+func sortedKeys[V any](m map[string]V) []string {
+	keys := make([]string, 0, len(m))
+	for k := range m {
+		keys = append(keys, k)
+	}
+	sort.Strings(keys)
+	return keys
 }
 
 // RenderDiffMarkdown renders diff results as markdown for MR comments.
@@ -60,19 +65,18 @@ func RenderDiffMarkdown(results []diff.DiffResult, opts MarkdownOptions) string
 		if content == "" {
 			continue
 		}
+		teamHeader := result.Team
 		if result.Team == "(global)" {
-			sb.WriteString("### Global (default.yml)\n\n")
-		} else {
-			sb.WriteString(fmt.Sprintf("### %s\n\n", result.Team))
+			teamHeader = "Global (default.yml)"
 		}
+		sb.WriteString(fmt.Sprintf("### %s\n\n", teamHeader))
 		sb.WriteString(content)
 		sb.WriteString("\n")
 
 		for _, rd := range []diff.ResourceDiff{result.Policies, result.Queries, result.Software, result.Profiles} {
-			a, m, d := countResourceChanges(rd)
-			totalAdded += a
-			totalModified += m
-			totalDeleted += d
+			totalAdded += len(rd.Added)
+			totalModified += len(rd.Modified)
+			totalDeleted += len(rd.Deleted)
 		}
 	}
 
@@ -87,7 +91,7 @@ func RenderDiffMarkdown(results []diff.DiffResult, opts MarkdownOptions) string
 		totalAdded, totalModified, totalDeleted))
 
 	if warning := buildPermissionWarning(results); warning != "" {
-		sb.WriteString(fmt.Sprintf("\n**Warning:** %s\n", warning))
+		sb.WriteString(fmt.Sprintf("\n⚠️ %s\n", warning))
 	}
 
 	writeMarker(&sb, opts.Marker)
@@ -162,11 +166,7 @@ func renderFieldsMarkdown(fields map[string]diff.FieldDiff) string {
 		return ""
 	}
 	var parts []string
-	var names []string
-	for name := range fields {
-		names = append(names, name)
-	}
-	sort.Strings(names)
+	names := sortedKeys(fields)
 	for _, name := range names {
 		fd := fields[name]
 		parts = append(parts, fmt.Sprintf("`%s`: `%s` -> `%s`", name, fd.Old, fd.New))
@@ -207,11 +207,7 @@ func buildPermissionWarning(results []diff.DiffResult) string {
 		return ""
 	}
 
-	resources := make([]string, 0, len(unavailable))
-	for r := range unavailable {
-		resources = append(resources, r)
-	}
-	sort.Strings(resources)
+	resources := sortedKeys(unavailable)
 	return fmt.Sprintf("Token lacks read access to: %s. Full-access token required for a complete diff.", strings.Join(resources, ", "))
 }
 
@@ -254,11 +250,7 @@ func renderLabelsMarkdown(results []diff.DiffResult) string {
 			sb.WriteString(fmt.Sprintf("- 🏷️ `%s`\n", l.Name))
 		}
 	}
-	var missingNames []string
-	for name := range missingSeen {
-		missingNames = append(missingNames, name)
-	}
-	sort.Strings(missingNames)
+	missingNames := sortedKeys(missingSeen)
 	for _, name := range missingNames {
 		l := missingSeen[name]
 		sb.WriteString(fmt.Sprintf("- 🚫 `%s` **NOT FOUND** (referenced by %s)\n", l.Name, l.ReferencedBy))

internal/output/markdown_test.go

@@ -7,6 +7,24 @@ import (
 	"github.com/TsekNet/fleet-plan/internal/diff"
 )
 
+func assertOutputContains(t *testing.T, out string, substrings []string) {
+	t.Helper()
+	for _, s := range substrings {
+		if !strings.Contains(out, s) {
+			t.Errorf("expected %q in output, got:\n%s", s, out)
+		}
+	}
+}
+
+func assertOutputExcludes(t *testing.T, out string, substrings []string) {
+	t.Helper()
+	for _, s := range substrings {
+		if strings.Contains(out, s) {
+			t.Errorf("did not expect %q in output, got:\n%s", s, out)
+		}
+	}
+}
+
 func TestRenderDiffMarkdown(t *testing.T) {
 	tests := []struct {
 		name     string
@@ -169,16 +187,8 @@ func TestRenderDiffMarkdown(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			out := RenderDiffMarkdown(tt.results, tt.opts)
-			for _, want := range tt.wantAll {
-				if !strings.Contains(out, want) {
-					t.Errorf("expected %q in output, got:\n%s", want, out)
-				}
-			}
-			for _, notWant := range tt.wantNone {
-				if strings.Contains(out, notWant) {
-					t.Errorf("did not expect %q in output, got:\n%s", notWant, out)
-				}
-			}
+			assertOutputContains(t, out, tt.wantAll)
+			assertOutputExcludes(t, out, tt.wantNone)
 		})
 	}
 }