rework buffs scanning #342
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Not tested |
Alessandro-Barbieri
force-pushed
the
buffs_scanning
branch
2 times, most recently
from
d3d6ffc to
8c849c1
Compare
Alessandro-Barbieri
force-pushed
the
buffs_scanning
branch
from
8c849c1 to
1b46707
Compare
Contributor
Author
|
which style do you prefer between for ... do
if a then
foo
elseif b then
bar
baz
elseif c then
foo
bar
end
endfor ... do
if a or c then
foo
end
if b or c then
bar
end
if b then
baz
end
endand between for ... do
if ... then
...
elseif ... then
...
end
if ECS.IsSod do
if ... then
...
elseif ... then
...
end
elseif ECS.IsTbc do
if ... then
...
elseif ... then
...
end
end
endfor ... do
if ... then
...
if ECS.IsSod do
...
elseif ECS.IsTbc do
...
end
elseif ... then
...
if ECS.IsSod do
...
elseif ECS.IsTbc do
...
end
end
end |
Owner
In both cases I'd say the first alternative. Kind of depends on the conditionals though. |
* check for more parry abilities * split enemy miss chance, dodge, parry, dodge and block calculation
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [leafo/gh-actions-lua](https://github.com/leafo/gh-actions-lua) from 10 to 11. - [Release notes](https://github.com/leafo/gh-actions-lua/releases) - [Commits](leafo/gh-actions-lua@v10...v11) --- updated-dependencies: - dependency-name: leafo/gh-actions-lua dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [leafo/gh-actions-luarocks](https://github.com/leafo/gh-actions-luarocks) from 4 to 5. - [Release notes](https://github.com/leafo/gh-actions-luarocks/releases) - [Commits](leafo/gh-actions-luarocks@v4...v5) --- updated-dependencies: - dependency-name: leafo/gh-actions-luarocks dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Contributor
Author
|
idk why luacheck is complaining |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #341