test: remove obsolete gettime check#274
Closed
Aquileo-hub wants to merge 1 commit into
Closed
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the obsolete
gettimeunit test that checks whetherGetTime()fits in 32 bits.What changed
gettimecompatibility test fromsrc/test/util_tests.cpp.util_time_GetTimecoverage in place for mock time and chrono precision handling.How tested
git diff --checkrg -n "BOOST_AUTO_TEST_CASE\\(gettime\\)|mingw/wine issue #3494|0xffffffff" src/test/util_tests.cpp(no matches)Not run:
src/test/test_BGL --run_test=util_tests, because this checkout does not have a configured build or test binary yet.Related issue/bounty
Fixes #143.
Also submitted under the public BGL PR bounty hunt (#32/#39) if maintainers consider this change eligible.
Notes
This is intentionally a narrow cleanup PR matching the issue scope.