Skip to content

test: remove obsolete gettime check#274

Closed
Aquileo-hub wants to merge 1 commit into
BitgesellOfficial:masterfrom
Aquileo-hub:fix/remove-obsolete-gettime-test
Closed

test: remove obsolete gettime check#274
Aquileo-hub wants to merge 1 commit into
BitgesellOfficial:masterfrom
Aquileo-hub:fix/remove-obsolete-gettime-test

Conversation

@Aquileo-hub
Copy link
Copy Markdown

Summary

Removes the obsolete gettime unit test that checks whether GetTime() fits in 32 bits.

What changed

  • Deleted the old MinGW/Wine gettime compatibility test from src/test/util_tests.cpp.
  • Left the modern util_time_GetTime coverage in place for mock time and chrono precision handling.

How tested

  • git diff --check
  • rg -n "BOOST_AUTO_TEST_CASE\\(gettime\\)|mingw/wine issue #3494|0xffffffff" src/test/util_tests.cpp (no matches)

Not run: src/test/test_BGL --run_test=util_tests, because this checkout does not have a configured build or test binary yet.

Related issue/bounty

Fixes #143.
Also submitted under the public BGL PR bounty hunt (#32/#39) if maintainers consider this change eligible.

Notes

This is intentionally a narrow cleanup PR matching the issue scope.

@Aquileo-hub
Copy link
Copy Markdown
Author

I noticed after opening this that #269 already contains the same focused change for #143. Closing this PR to avoid duplicate review noise. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: Clean up tests gettime is outdated

1 participant