Added fallback logic for detecting file content-type when S3 returns generic #15635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the CLERKIEAI Team on Vercel. A member of the Team first needs to authorize it. |
|
|
|
@krrishdholakia Could you help review and merge this PR? |
|
@ishaan-jaff Could you help review and merge this PR? |
ishaan-jaff
requested changes
Oct 28, 2025
| ) | ||
|
|
||
| # Fallback logic when content-type is missing or generic | ||
| if not content_type or content_type in ["binary/octet-stream", "application/octet-stream"]: |
There was a problem hiding this comment.
can we have this be a helper in litellm_core_utils
There was a problem hiding this comment.
Agree, updated.
Thank you!
…om/langpingxue/litellm into litellm_image_content_type_enhance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using Bedrock with S3-hosted files, if the S3 object's Content-Type is not correctly set (e.g.,
binary/octet-streaminstead ofimage/png), Bedrock fails to recognize the files format.Solution
Implemented two-tier fallback mechanism:
.png→image/png)Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🆕 New Feature
Changes
BedrockImageProcessor._post_call_image_processing()to add fallback logicNew test passing locally