fix(tests): fix tests for default_lifetime usage (#1)

Author: fferriere

README.md

@@ -49,4 +49,4 @@ You can execute `make test` to execute all tests.
 
 * [ ] Create Github Actions to execute tests
 * [ ] Cleanup configuration
-* [ ] Create version 1.0 for Symfony 5.4 + PHP 7.4 and version 2.0 for Symfony 6.0 and PHP 8.0, using branch `feat/php8`
+* [ ] Create version 1.0 for Symfony 5.4 + PHP 7.4 and version 2.0 for Symfony 6.0 and PHP 8.0, using branch `feat/php8`

src/DependencyInjection/AddStaleCacheLifetime.php

@@ -9,7 +9,7 @@
 
 class AddStaleCacheLifetime implements CompilerPassInterface
 {
-    public function process(ContainerBuilder $container)
+    public function process(ContainerBuilder $container): void
     {
         $cachePoolServices = $container->findTaggedServiceIds('cache.pool');
         $staleCacheServices = $container->findTaggedServiceIds('bedrock_stale_cache.stale_cache');
@@ -25,6 +25,12 @@ public function process(ContainerBuilder $container)
         }
     }
 
+    /**
+     * @param array<string, array<array{
+     *     'name'?: string,
+     *     'default_lifetime'?: int,
+     * }>> $cachePoolServices
+     */
     private function findCachePoolDefaultLifetime(string $cachePool, array $cachePoolServices): ?int
     {
         foreach ($cachePoolServices as $serviceId => $tags) {

tests/Unit/Cache/StaleTest.php

@@ -295,6 +295,49 @@ public function testGetItemMissWithFailingCallback(): void
         $this->testedInstance->get($key, $callback, $beta, $metadata);
     }
 
+    public function testGetItemWithDefaultLifetime()
+    {
+        $defaultLifetime = rand(100, 200);
+
+        $key = uniqid('key_', true);
+        $value = uniqid('value_', true);
+        $callback = fn (ItemInterface $item) => $value;
+        $beta = (float) rand(1, 10);
+
+        $cacheItem = new CacheItem();
+
+        $expectedExpiryMin = microtime(true) + self::DEFAULT_MAX_STALE + $defaultLifetime;
+
+        $metadataArgument = Argument::any();
+        $this->internalCache->get($key, Argument::any(), 0, $metadataArgument)
+            // Use cached value
+            ->willReturn($value);
+
+        $this->internalCache->get($key, Argument::any(), \INF, $metadataArgument)
+            ->shouldBeCalledOnce()
+            // Execute $callback
+            ->will(function ($args) use ($cacheItem) {
+                $save = true;
+
+                return $args[1]($cacheItem, $save);
+            });
+
+        $this->testedInstance->setDefaultLifetime($defaultLifetime);
+
+        // Item is in cache, but in stale mode
+        // Value cannot be refreshed due to failing source
+        $metadata = [ItemInterface::METADATA_EXPIRY => microtime(true) + self::DEFAULT_MAX_STALE / 2];
+        $result = $this->testedInstance->get($key, $callback, $beta, $metadata);
+
+        $expectedExpiryMax = microtime(true) + self::DEFAULT_MAX_STALE + $defaultLifetime;
+
+        self::assertEquals($value, $result);
+
+        $cacheItemExpiry = self::getCacheItemExpiry($cacheItem);
+        self::assertGreaterThan($expectedExpiryMin, $cacheItemExpiry);
+        self::assertLessThan($expectedExpiryMax, $cacheItemExpiry);
+    }
+
     public function testDelete(): void
     {
         $key = uniqid('key_', true);
@@ -321,16 +364,18 @@ public function testInvalidateTags(): void
         self::assertEquals($success, $result);
     }
 
-    public function testGetItemWithDefaultLifetime()
-    {
-        // TODO
-    }
-
     private static function assertCacheItemExpiryEquals(float $expiry, CacheItem $cacheItem)
     {
         $cacheItemExpiry = (\Closure::bind(function (CacheItem $item) {
             return $item->expiry;
         }, null, CacheItem::class))($cacheItem);
         self::assertEquals($expiry, $cacheItemExpiry);
     }
+
+    private static function getCacheItemExpiry(CacheItem $cacheItem)
+    {
+        return (\Closure::bind(function (CacheItem $item) {
+            return $item->expiry;
+        }, null, CacheItem::class))($cacheItem);
+    }
 }