chore: CNS - Only log CreateOrUpdateNetworkContainer on failure

peterfelts · peterfelts · commit 3a3700fa2950 · 2025-09-18T16:46:40.000-07:00
diff --git a/cns/restserver/api.go b/cns/restserver/api.go
@@ -567,9 +567,10 @@ func (service *HTTPRestService) createOrUpdateNetworkContainer(w http.ResponseWr
 	// If the NC was created successfully, log NC snapshot.
 	if returnCode == types.Success {
 		logNCSnapshot(req)
+	} else {
+		// Only emit response trace/log for non-success responses to avoid noisy success logs.
+		logger.Response(service.Name, reserveResp, resp.ReturnCode, err)
 	}
-
-	logger.Response(service.Name, reserveResp, resp.ReturnCode, err)
 }
 
 func (service *HTTPRestService) getNetworkContainerByID(w http.ResponseWriter, r *http.Request) {

Original file line number	Diff line number	Diff line change
`@@ -567,9 +567,10 @@ func (service *HTTPRestService) createOrUpdateNetworkContainer(w http.ResponseWr`
`567`	`567`	`// If the NC was created successfully, log NC snapshot.`
`568`	`568`	`if returnCode == types.Success {`
`569`	`569`	`logNCSnapshot(req)`
	`570`	`+ } else {`
	`571`	`+ // Only emit response trace/log for non-success responses to avoid noisy success logs.`
	`572`	`+ logger.Response(service.Name, reserveResp, resp.ReturnCode, err)`
`570`	`573`	`}`
`571`		`-`
`572`		`- logger.Response(service.Name, reserveResp, resp.ReturnCode, err)`
`573`	`574`	`}`
`574`	`575`
`575`	`576`	`func (service HTTPRestService) getNetworkContainerByID(w http.ResponseWriter, r http.Request) {`