Issues #41 #42 #43 ... daemon clean up #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Static code analysis fix (preparation) _004 (Issue Avnu#40) Make SystemdWatchdogHandler object to be created in main() for proper cleanup during exit. watchodg_setup() changed to a public member of SystemdWatchdogHandler class.
Contributor
Author
|
Please review :-) |
Contributor
Author
|
Hello, hello! Any comments here? |
Contributor
Author
|
Anybody out there? |
Contributor
|
I will skip that for now. It is not trivial, so requires more time for analysis and testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds systemd watchdog refactoring and some clean up code that fixes a bunch of memory leaks reported by static code analysis (see details in commit messages).