Update test factory usage to static method calls (#2565)

Author: pfefferle

tests/phpunit/tests/includes/class-test-search.php

@@ -18,7 +18,7 @@ class Test_Search extends \WP_UnitTestCase {
 	 */
 	public function test_regular_search_unchanged() {
 		// Create a test post.
-		$post_id = $this->factory->post->create(
+		$post_id = self::factory()->post->create(
 			array(
 				'post_title'   => 'Test Post About Cats',
 				'post_content' => 'This is a test post about cats and dogs.',

tests/phpunit/tests/includes/handler/class-test-accept.php

@@ -122,7 +122,7 @@ public function test_handle_accept_moves_user_from_pending_to_following() {
 		$object_guid = 'https://example.com/actor/123';
 		$outbox_guid = 'https://example.com/outbox/123';
 
-		$outbox_post_id = $this->factory->post->create(
+		$outbox_post_id = self::factory()->post->create(
 			array(
 				'post_type'   => 'ap_outbox',
 				'post_status' => 'publish',
@@ -133,7 +133,7 @@ public function test_handle_accept_moves_user_from_pending_to_following() {
 		\add_post_meta( $outbox_post_id, '_activitypub_activity_type', 'Follow' );
 
 		// Create remote actor post.
-		$post_id = $this->factory->post->create(
+		$post_id = self::factory()->post->create(
 			array(
 				'post_type'   => Remote_Actors::POST_TYPE,
 				'post_status' => 'publish',

tests/phpunit/tests/includes/handler/class-test-reject.php

@@ -123,7 +123,7 @@ public function test_handle_reject_keeps_user_in_pending() {
 		$object_guid = 'https://example.com/actor/123';
 		$outbox_guid = 'https://example.com/outbox/123';
 
-		$outbox_post_id = $this->factory->post->create(
+		$outbox_post_id = self::factory()->post->create(
 			array(
 				'post_type'   => Outbox::POST_TYPE,
 				'post_status' => 'publish',
@@ -134,7 +134,7 @@ public function test_handle_reject_keeps_user_in_pending() {
 		\add_post_meta( $outbox_post_id, '_activitypub_activity_type', 'Follow' );
 
 		// Create remote actor post.
-		$post_id = $this->factory->post->create(
+		$post_id = self::factory()->post->create(
 			array(
 				'post_type'   => Remote_Actors::POST_TYPE,
 				'post_status' => 'publish',

tests/phpunit/tests/includes/handler/class-test-undo.php

@@ -175,7 +175,7 @@ public function test_handle_undo_comment_activities( $actor_url, $activity_type,
 		\add_filter( 'pre_get_remote_metadata_by_actor', $mock_actor_metadata );
 
 		// Create a test post.
-		$post_id = $this->factory->post->create(
+		$post_id = self::factory()->post->create(
 			array(
 				'post_author' => self::$user_id,
 				'post_title'  => 'Test Post for ' . $description,

tests/phpunit/tests/includes/transformer/class-test-base.php

@@ -84,7 +84,7 @@ public function get_object_var_keys() {
 	 * @param array  $expected_audience  The expected audience.
 	 */
 	public function test_set_audience( $content_visibility, $object_attributes, $expected_audience ) {
-		$post_id = $this->factory->post->create(
+		$post_id = self::factory()->post->create(
 			array(
 				'post_title'   => 'Test Post',
 				'post_content' => 'Test content that is longer than the note length limit',

tests/phpunit/tests/includes/transformer/class-test-post.php

@@ -55,7 +55,7 @@ public function tear_down() {
 	public function test_get_type_returns_configured_type_when_option_set() {
 		update_option( 'activitypub_object_type', 'Article' );
 
-		$post_id = $this->factory->post->create(
+		$post_id = self::factory()->post->create(
 			array(
 				'post_title'   => 'Test Post',
 				'post_content' => 'Test content that is longer than the note length limit',
@@ -81,7 +81,7 @@ public function test_get_type_returns_configured_type_when_option_set() {
 	 * @param string $description    Description of the test case.
 	 */
 	public function test_get_type( $post_data, $post_format, $expected_type, $description ) {
-		$post_id = $this->factory->post->create( $post_data );
+		$post_id = self::factory()->post->create( $post_data );
 
 		if ( $post_format ) {
 			set_post_format( $post_id, $post_format );
@@ -180,7 +180,7 @@ public function test_get_type_respects_post_type_title_support() {
 			)
 		);
 
-		$post_id = $this->factory->post->create(
+		$post_id = self::factory()->post->create(
 			array(
 				'post_title'   => 'Test Post',
 				'post_content' => str_repeat( 'Long content. ', 100 ),
@@ -213,7 +213,7 @@ public function test_get_type_respects_post_format_support() {
 			)
 		);
 
-		$post_id = $this->factory->post->create(
+		$post_id = self::factory()->post->create(
 			array(
 				'post_title'   => 'Test Post',
 				'post_content' => str_repeat( 'Long content. ', 100 ),
@@ -496,7 +496,7 @@ public function test_get_media_from_blocks_handles_multiple_blocks() {
 	 * @covers ::get_icon
 	 */
 	public function test_get_icon() {
-		$post_id = $this->factory->post->create(
+		$post_id = self::factory()->post->create(
 			array(
 				'post_title'   => 'Test Post',
 				'post_content' => 'Test content',
@@ -620,7 +620,7 @@ public function create_upload_object( $file, $parent_id = 0 ) {
 	 */
 	public function test_preview_property() {
 		// Create a test post of type "Article".
-		$post = $this->factory->post->create_and_get(
+		$post = self::factory()->post->create_and_get(
 			array(
 				'post_title'   => 'Test Article',
 				'post_content' => str_repeat( 'Long content. ', 100 ),
@@ -638,7 +638,7 @@ public function test_preview_property() {
 		$this->assertNotEmpty( $preview['content'] );
 
 		// Create a test post of type "Note" (short content).
-		$note_post = $this->factory->post->create_and_get(
+		$note_post = self::factory()->post->create_and_get(
 			array(
 				'post_title'   => '',
 				'post_content' => 'Short note content',

tests/phpunit/tests/integration/class-test-akismet.php

@@ -40,15 +40,15 @@ public static function wpSetUpBeforeClass( $factory ) {
 	 */
 	public function test_comment_row_actions() {
 		// Create a normal comment.
-		$normal_comment_id = $this->factory->comment->create(
+		$normal_comment_id = self::factory()->comment->create(
 			array(
 				'comment_post_ID' => self::$post_id,
 				'comment_content' => 'Normal comment',
 			)
 		);
 
 		// Create an ActivityPub comment.
-		$ap_comment_id = $this->factory->comment->create(
+		$ap_comment_id = self::factory()->comment->create(
 			array(
 				'comment_post_ID' => self::$post_id,
 				'comment_content' => 'ActivityPub comment',

tests/phpunit/tests/integration/class-test-stream-connector.php

@@ -343,7 +343,7 @@ public function test_callback_activitypub_outbox_processing_complete() {
 		}
 
 		// Create a mock outbox post.
-		$outbox_post_id = $this->factory->post->create(
+		$outbox_post_id = self::factory()->post->create(
 			array(
 				'post_type'  => 'ap_outbox',
 				'post_title' => get_permalink( self::$post_id ),
@@ -394,7 +394,7 @@ public function test_callback_activitypub_outbox_processing_batch_complete() {
 		}
 
 		// Create a mock outbox post.
-		$outbox_post_id = $this->factory->post->create(
+		$outbox_post_id = self::factory()->post->create(
 			array(
 				'post_type'  => 'ap_outbox',
 				'post_title' => get_permalink( self::$post_id ),