Add global customizations for AutoFixture #7

Prevent the creation of complex object graphs and the population of auto
properties.

Author: JSkimming

src/AutoTest.ArgumentNullException/ArgumentNullExceptionFixture.cs

@@ -8,7 +8,6 @@
     using AutoTest.ArgNullEx.Filter;
     using AutoTest.ArgNullEx.Framework;
     using Ploeh.AutoFixture;
-    using Ploeh.AutoFixture.Kernel;
 
     /// <summary>
     /// A custom builder to generate the parameter specimens to execute methods to ensure they correctly throw <see cref="ArgumentNullException"/> errors.
@@ -53,28 +52,28 @@ public ArgumentNullExceptionFixture(Assembly assemblyUnderTest)
         /// Initializes a new instance of the <see cref="ArgumentNullExceptionFixture" /> class.
         /// </summary>
         /// <param name="assemblyUnderTest">The assembly under test.</param>
-        /// <param name="builder">The specimen builder.</param>
-        public ArgumentNullExceptionFixture(Assembly assemblyUnderTest, ISpecimenBuilder builder)
-            : this(assemblyUnderTest, builder, DiscoverFilters())
+        /// <param name="fixture">The specimen fixture.</param>
+        public ArgumentNullExceptionFixture(Assembly assemblyUnderTest, IFixture fixture)
+            : this(assemblyUnderTest, fixture, DiscoverFilters())
         {
         }
 
         /// <summary>
         /// Initializes a new instance of the <see cref="ArgumentNullExceptionFixture" /> class.
         /// </summary>
         /// <param name="assemblyUnderTest">The assembly under test.</param>
-        /// <param name="builder">The specimen builder.</param>
+        /// <param name="fixture">The specimen fixture.</param>
         /// <param name="filters">The list of filters.</param>
-        public ArgumentNullExceptionFixture(Assembly assemblyUnderTest, ISpecimenBuilder builder, List<IFilter> filters)
-            : this(assemblyUnderTest, new SpecimenProvider(builder), filters)
+        public ArgumentNullExceptionFixture(Assembly assemblyUnderTest, IFixture fixture, List<IFilter> filters)
+            : this(assemblyUnderTest, new SpecimenProvider(fixture), filters)
         {
         }
 
         /// <summary>
         /// Initializes a new instance of the <see cref="ArgumentNullExceptionFixture" /> class.
         /// </summary>
         /// <param name="assemblyUnderTest">The assembly under test.</param>
-        /// <param name="specimenProvider">The builder.</param>
+        /// <param name="specimenProvider">The specimen provider.</param>
         /// <param name="filters">The list of filters.</param>
         internal ArgumentNullExceptionFixture(Assembly assemblyUnderTest, ISpecimenProvider specimenProvider, List<IFilter> filters)
         {

src/AutoTest.ArgumentNullException/SpecimenProvider.cs

@@ -2,7 +2,9 @@
 {
     using System;
     using System.Collections.Generic;
+    using System.Linq;
     using System.Reflection;
+    using Ploeh.AutoFixture;
     using Ploeh.AutoFixture.Kernel;
 
     /// <summary>
@@ -18,13 +20,14 @@ internal class SpecimenProvider : ISpecimenProvider
         /// <summary>
         /// Initializes a new instance of the <see cref="SpecimenProvider"/> class.
         /// </summary>
-        /// <param name="builder">The specimen builder.</param>
-        public SpecimenProvider(ISpecimenBuilder builder)
+        /// <param name="fixture">The specimen fixture.</param>
+        public SpecimenProvider(IFixture fixture)
         {
-            if (builder == null)
-                throw new ArgumentNullException("builder");
+            if (fixture == null)
+                throw new ArgumentNullException("fixture");
 
-            _builder = builder;
+            _builder = fixture;
+            GlobalCustomizations(fixture);
         }
 
         /// <summary>
@@ -89,6 +92,26 @@ object ISpecimenProvider.CreateInstance(Type type)
             return Resolve(type);
         }
 
+        /// <summary>
+        /// Added the global customizations to the <paramref name="fixture"/>.
+        /// </summary>
+        /// <param name="fixture">The test fixture.</param>
+        private static void GlobalCustomizations(IFixture fixture)
+        {
+            if (fixture == null)
+                throw new ArgumentNullException("fixture");
+
+            // Don't need to create complex graphs, just need objects.
+            var throwingRecursionBehavior = fixture.Behaviors.OfType<ThrowingRecursionBehavior>().SingleOrDefault();
+            if (throwingRecursionBehavior != null)
+            {
+                fixture.Behaviors.Remove(throwingRecursionBehavior);
+                fixture.Behaviors.Add(new OmitOnRecursionBehavior());
+            }
+
+            fixture.OmitAutoProperties = true;
+        }
+
         /// <summary>
         /// Resolves the <paramref name="parameter"/> specimen.
         /// </summary>

src/Tests/AutoTest.ArgumentNullException.Tests/AutoFixtureCustomizations.cs

@@ -34,13 +34,6 @@ private static ParameterInfo GetParameterInfo(object unused = null)
 
         void ICustomization.Customize(IFixture fixture)
         {
-            var throwingRecursionBehavior = fixture.Behaviors.OfType<ThrowingRecursionBehavior>().SingleOrDefault();
-            if (throwingRecursionBehavior != null)
-            {
-                fixture.Behaviors.Remove(throwingRecursionBehavior);
-                fixture.Behaviors.Add(new OmitOnRecursionBehavior());
-            }
-
             fixture.Inject(ParameterInfo);
             fixture.Customize<CatchInfo>(
                 composer => composer.FromFactory(

src/Tests/AutoTest.ArgumentNullException.Tests/SpecimenProviderShould.cs

@@ -14,11 +14,46 @@ public class SpecimenProviderShould
     {
         [Theory, AutoMock]
         internal void InitialiseBuilder(
-            IFixture builder,
+            IFixture fixture,
             SpecimenProvider sut)
         {
             // Act
-            Assert.Same(builder, sut.Builder);
+            Assert.Same(fixture, sut.Builder);
+        }
+
+        [Theory, AutoMock]
+        internal void AddGlobalCustomizations(
+            IFixture fixture,
+            SpecimenProvider sut)
+        {
+            // Act/Assert
+            Assert.Same(fixture, sut.Builder);
+            Assert.Empty(fixture.Behaviors.OfType<ThrowingRecursionBehavior>());
+            Assert.Equal(1, fixture.Behaviors.OfType<OmitOnRecursionBehavior>().Count());
+            Assert.True(fixture.OmitAutoProperties);
+        }
+
+        [Theory, AutoMock]
+        internal void AddGlobalCustomizationsIsIdempotent(
+            IFixture fixture)
+        {
+            // Arrange
+            var throwingRecursionBehavior = fixture.Behaviors.OfType<ThrowingRecursionBehavior>().SingleOrDefault();
+            if (throwingRecursionBehavior != null)
+            {
+                fixture.Behaviors.Remove(throwingRecursionBehavior);
+                fixture.Behaviors.Add(new OmitOnRecursionBehavior());
+            }
+            Assert.False(fixture.OmitAutoProperties);
+
+            // Act
+            var sut = new SpecimenProvider(fixture);
+
+            // Assert
+            Assert.Same(fixture, sut.Builder);
+            Assert.Empty(fixture.Behaviors.OfType<ThrowingRecursionBehavior>());
+            Assert.Equal(1, fixture.Behaviors.OfType<OmitOnRecursionBehavior>().Count());
+            Assert.True(fixture.OmitAutoProperties);
         }
 
         [Theory, AutoMock]

src/Tests/AutoTest.ExampleLibrary.Tests/RequiresArgNullExAutoMoqAttribute.cs

@@ -1,7 +1,6 @@
 namespace AutoTest.ExampleLibrary
 {
     using System;
-    using System.Linq;
     using System.Reflection;
     using AutoTest.ArgNullEx;
     using AutoTest.ArgNullEx.Xunit;
@@ -31,16 +30,6 @@ private static IArgumentNullExceptionFixture CreateFixture(Assembly assemblyUnde
         {
             var fixture = new Fixture().Customize(new AutoMoqCustomization());
 
-            var throwingRecursionBehavior = fixture.Behaviors.OfType<ThrowingRecursionBehavior>().SingleOrDefault();
-            if (throwingRecursionBehavior != null)
-            {
-                fixture.Behaviors.Remove(throwingRecursionBehavior);
-                fixture.Behaviors.Add(new OmitOnRecursionBehavior());
-            }
-
-            // Don't need to create complex graphs, just need objects.
-            fixture.OmitAutoProperties = true;
-
             return new ArgumentNullExceptionFixture(assemblyUnderTest, fixture)
                 .ExcludeType(typeof(ComplexGenericMethods)); // Exclude until it can be tested.
         }