Clean Code for Blurring and Upscaling Process

[takeny1998]

I'd like to discuss about changing name of functions and variables related to the upscaling process.

1. expand_image method in Painting class.

• I think expand_image is a good to describe the behavior,
• but the upscale_image looks better to express Upscaling Process.

2. target_size parameter in expand_image method.

• it can be mislead users think that they are changing image size as fixed size.
• since we're scaling the image, upscaling_ratio seems right. and its type should be float.

3. blurring method in Painting Class.

• A function's name should clearly descible its behavior and its target.
• I think blurring should include the target, so **blur_image is more correct.**

what do you think about those? I'd like to hear.

[Minku-Koo]

Oh that is gooooood idea.

3 things that you suggest is nive opinion.

Can you help me? try change and PR to us.

Thank you :)

[takeny1998]

resolved with PR #18

in addition, I'd like to discuss 2 things.

1. remove is_upscale bool flag.

   • upscale_image has ratio parameter for now, and I handled that do not perform upscaling image if users sets it as 1.0.
   • so, why don't we remove is_upscale? then it'll makes user handles upscaling intense easier.
   • but, default value that is_upscale is false, so idk how do I set default upscaling_ratio value if is_upscale removed.

2. auto calculation in upscaling.

   • to fit the image size to 5000 pixel, we are calculating ratio an integer value.
   • BUT, if the image size is 4999 pixel, the result will be 9998 pixel. is the calculation what you intended?
   • if not, just calculate it an float. it will be more accurate.

Thanks :)