test: add array destructuring test case and improve parent node traversal

Author: Akronae

package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-exception-handling",
-  "version": "1.5.4",
+  "version": "1.5.5",
   "description": "💣 Lints unhandled functions that might throw errors. For JavaScript/TypeScript eslint.",
   "author": {
     "email": "[email protected]",

src/rules/no-unhandled/no-unhandled.spec.ts

@@ -13,6 +13,7 @@ await testFile(
 await testFile("src/rules/no-unhandled/tests/import-ok.ts", [rule.name], []);
 await testFile("src/rules/no-unhandled/tests/import-ok-2.ts", [rule.name], []);
 await testFile("src/rules/no-unhandled/tests/basic-ok.ts", [rule.name], []);
+await testFile("src/rules/no-unhandled/tests/basic-ok-2.ts", [rule.name], []);
 await testFile(
   "src/rules/no-unhandled/tests/basic-err.ts",
   [rule.name],
@@ -49,6 +50,15 @@ await testFile(
     },
   ]
 );
+await testFile(
+  "src/rules/no-unhandled/tests/basic-err-4.ts",
+  [rule.name],
+  [
+    {
+      messageId: "noUnhandled",
+    },
+  ]
+);
 await testFile("src/rules/no-unhandled/tests/module-ok.ts", [rule.name], []);
 await testFile(
   "src/rules/no-unhandled/tests/private-identifier-ok.ts",
@@ -101,3 +111,8 @@ await testFile(
   ]
 );
 await testFile("src/rules/no-unhandled/tests/alias-ok.ts", [rule.name], []);
+await testFile(
+  "src/rules/no-unhandled/tests/array-destructuring-ok.ts",
+  [rule.name],
+  []
+);

src/rules/no-unhandled/no-unhandled.ts

@@ -1,13 +1,13 @@
-import { isIdentifier } from "@typescript-eslint/utils/ast-utils";
+import { createRule } from "@/src/rules/create-rule";
 import {
-  findInParent,
-  isFunctionDeclaration,
   findInChildren,
+  findInParent,
   getCallExprId,
+  isFunctionDeclaration,
   isMethodDefinition,
 } from "@/src/utils";
-import { createRule } from "@/src/rules/create-rule";
 import { canFuncThrow, canFuncThrowClear } from "@/src/utils/can-func-throw";
+import { isIdentifier } from "@typescript-eslint/utils/ast-utils";
 
 const name = "no-unhandled";
 const rule = createRule({

src/rules/no-unhandled/tests/array-destructuring-ok.ts

@@ -0,0 +1,10 @@
+const pairs = new Map<string, number>([
+  ["foo", 1],
+  ["bar", 2],
+]);
+
+Array.from(pairs.entries())
+  .filter(([, count]) => count > 1)
+  .forEach(([identifier]) => {
+    console.log(identifier);
+  });

src/rules/no-unhandled/tests/basic-err-4.ts

@@ -0,0 +1,5 @@
+function abcd() {
+  throw new Error("heyyyy!");
+}
+
+abcd();

src/rules/no-unhandled/tests/basic-ok-2.ts

@@ -0,0 +1,3 @@
+function abc() {
+  throw new Error("heyyyy!");
+}

src/utils/can-func-throw.ts

@@ -1,18 +1,18 @@
-import { TSESTree } from "@typescript-eslint/utils";
-import { isIdentifier } from "@typescript-eslint/utils/ast-utils";
 import {
+  exploreChildren,
+  findInChildren,
   findInParent,
+  getFunctionId,
   isCallExpression,
+  isCatchClause,
   isThrowStatement,
   isTryStatement,
-  findInChildren,
-  exploreChildren,
-  getFunctionId,
   resolveFunc,
-  isCatchClause,
 } from "@/src/utils";
-import { RuleContext } from "@typescript-eslint/utils/ts-eslint";
 import { nativeThrowing } from "@/src/utils/native-throwing";
+import { TSESTree } from "@typescript-eslint/utils";
+import { isIdentifier } from "@typescript-eslint/utils/ast-utils";
+import { RuleContext } from "@typescript-eslint/utils/ts-eslint";
 
 const throwFunctions = new Set<string>();
 const scannedFunctions = new Set<string>();

src/utils/explore-children.ts

@@ -29,7 +29,7 @@ export function exploreChildren<T>(
       if (val && typeof val === "object") {
         if (Array.isArray(val)) {
           for (const v of val) {
-            if (v.type) {
+            if (v?.type) {
               if (explored.has(v)) continue;
               explored.add(v);
               const res = explore(v, node);
@@ -47,3 +47,22 @@ export function exploreChildren<T>(
   };
   return explore(node, node.parent);
 }
+
+// [
+//   "body",
+//   "params",
+//   "callee",
+//   "expression",
+//   "arguments",
+//   "block",
+//   "handler",
+//   "finalizer",
+//   "specifiers",
+//   "assertions",
+//   "argument",
+//   "property",
+//   "id",
+//   "object",
+//   "attributes",
+//   "declaration",
+// ];

src/utils/find-in-children.ts

@@ -5,9 +5,13 @@ import { exploreChildren } from "./explore-children";
 export function findInChildren<
   T extends TSESTree.Node,
   F extends (x: TSESTree.Node) => x is T
->(node: TSESTree.Node, predicate: F): InferGuardType<F> | undefined {
+>(
+  node: TSESTree.Node,
+  predicate: F,
+  filter?: (node: InferGuardType<F>) => boolean
+): InferGuardType<F> | undefined {
   return exploreChildren(node, (child, _parent, resolve) => {
-    if (predicate(child)) {
+    if (predicate(child) && (!filter || filter(child as InferGuardType<F>))) {
       resolve(child as InferGuardType<F>);
     }
   });

src/utils/find-in-parent.ts

@@ -1,4 +1,5 @@
 import { TSESTree } from "@typescript-eslint/types";
+import { findInChildren } from "./find-in-children";
 import { InferGuardType } from "./infer-guard-type";
 
 export function findInParent<
@@ -11,8 +12,15 @@ export function findInParent<
 ): InferGuardType<F> | undefined {
   let parent: TSESTree.Node | undefined = node.parent;
   while (parent) {
-    if (predicate(parent) && (!filter || filter(parent as InferGuardType<F>))) {
-      return parent as InferGuardType<F>;
+    const found = findInChildren(parent, predicate, (x) => {
+      return (
+        x.range[0] < node.range[0] &&
+        x.range[1] > node.range[1] &&
+        (!filter || filter(x as InferGuardType<F>))
+      );
+    });
+    if (found) {
+      return found;
     }
     parent = parent.parent;
   }