perf(ci): avoid loading unused sanitizer image

Author: Aethersailor

.github/workflows/build-dockerhub.yml

@@ -110,8 +110,7 @@ jobs:
             --file Dockerfile \
             --platform linux/amd64 \
             --target builder \
-            --load \
-            --tag "subconverter-request-sanitizer:${GITHUB_SHA}" \
+            --output type=cacheonly \
             --cache-from type=gha,scope=request-sanitizers \
             --cache-to type=gha,scope=request-sanitizers,mode=max \
             --progress plain \

tests/fixtures/ci/workflow-contract-oracle.json

@@ -1,8 +1,8 @@
 {
   "schema": 1,
   "source_sha": "47d2399444ac6abad78185c479a09d2bc4511536",
-  "contract_sha256": "6714d876c036e877835e93dba337f686425c9a537edf7254b8e6adcbffad2fec",
-  "workflow_diff_from_source": "none",
+  "contract_sha256": "35f179bba0e522e3bb17bc9aa382e4ef95591b554f180d96b19d9ece52385121",
+  "workflow_diff_from_source": "request-sanitizer-cache-only-output",
   "run_normalization": "universal-newlines-only",
   "step_fields": [
     "continue-on-error",

tests/fixtures/ci/workflow-contract.json

@@ -540,7 +540,7 @@
             },
             {
               "name": "Build and run request sanitizer targets",
-              "run": "|\nset -euo pipefail\nexport THREADS=\"$(nproc)\"\nexport SHA=\"$GITHUB_SHA\"\nexport VERSION=\"sanitizer-${GITHUB_SHA::7}\"\nexport BUILD_DATE=\"$(git show -s --format=%cI HEAD)\"\nexport BUILD_TESTS=true\nmapfile -t build_args < <(bash scripts/ci/docker-build-args.sh)\nargs=()\nfor arg in \"${build_args[@]}\"; do\n  [ -n \"$arg\" ] && args+=(--build-arg \"$arg\")\ndone\nargs+=(--build-arg ENABLE_SANITIZERS=true)\necho \"Sanitizer CMake option: -DENABLE_SANITIZERS=true\"\necho \"Sanitizer build targets: production runtime and all BUILD_TESTS targets\"\necho \"Sanitizer run targets: settings_view, settings_view_invariant_failure, compatibility_security_baseline\"\ndocker buildx build \\\n  --file Dockerfile \\\n  --platform linux/amd64 \\\n  --target builder \\\n  --load \\\n  --tag \"subconverter-request-sanitizer:${GITHUB_SHA}\" \\\n  --cache-from type=gha,scope=request-sanitizers \\\n  --cache-to type=gha,scope=request-sanitizers,mode=max \\\n  --progress plain \\\n  \"${args[@]}\" \\\n  .\n",
+              "run": "|\nset -euo pipefail\nexport THREADS=\"$(nproc)\"\nexport SHA=\"$GITHUB_SHA\"\nexport VERSION=\"sanitizer-${GITHUB_SHA::7}\"\nexport BUILD_DATE=\"$(git show -s --format=%cI HEAD)\"\nexport BUILD_TESTS=true\nmapfile -t build_args < <(bash scripts/ci/docker-build-args.sh)\nargs=()\nfor arg in \"${build_args[@]}\"; do\n  [ -n \"$arg\" ] && args+=(--build-arg \"$arg\")\ndone\nargs+=(--build-arg ENABLE_SANITIZERS=true)\necho \"Sanitizer CMake option: -DENABLE_SANITIZERS=true\"\necho \"Sanitizer build targets: production runtime and all BUILD_TESTS targets\"\necho \"Sanitizer run targets: settings_view, settings_view_invariant_failure, compatibility_security_baseline\"\ndocker buildx build \\\n  --file Dockerfile \\\n  --platform linux/amd64 \\\n  --target builder \\\n  --output type=cacheonly \\\n  --cache-from type=gha,scope=request-sanitizers \\\n  --cache-to type=gha,scope=request-sanitizers,mode=max \\\n  --progress plain \\\n  \"${args[@]}\" \\\n  .\n",
               "shell": "bash"
             }
           ]

tests/test_sanitizer_workflow_contract.py

@@ -25,6 +25,19 @@ def test_job_builds_the_instrumented_runtime_and_request_tests(self):
         self.assertIn("compatibility_security_baseline", self.sanitizer_job)
         self.assertNotIn("tests/statistics_v2_test.cpp", self.sanitizer_job)
 
+    def test_job_exports_only_the_reusable_cache(self):
+        self.assertIn("--output type=cacheonly", self.sanitizer_job)
+        self.assertIn(
+            "--cache-from type=gha,scope=request-sanitizers",
+            self.sanitizer_job,
+        )
+        self.assertIn(
+            "--cache-to type=gha,scope=request-sanitizers,mode=max",
+            self.sanitizer_job,
+        )
+        self.assertNotIn("--load", self.sanitizer_job)
+        self.assertNotIn("subconverter-request-sanitizer:", self.sanitizer_job)
+
     def test_sanitizer_flags_and_fail_closed_runtime_are_explicit(self):
         for flag in (
             "-fsanitize=address,undefined",