Support abstract classes implemented in Python that inherit SysModel #1197
+169
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schaubh
requested changes
Nov 25, 2025
juan-g-bonilla
force-pushed
the
feature/1191-py-sysmodel-directors
branch
from
531cb98 to
f6118a6
Compare
schaubh
approved these changes
Nov 25, 2025
juan-g-bonilla
force-pushed
the
feature/1191-py-sysmodel-directors
branch
from
f6118a6 to
c347c07
Compare
Errors are logged automatically for all methods implemented in Python. Sanity check for calling __init__ in the parent implemented without metaclass.
juan-g-bonilla
force-pushed
the
feature/1191-py-sysmodel-directors
branch
from
c347c07 to
1917234
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SysModelMixin, a new Python mixin that standardizes:logErrorwrapping of overridden director methods.super().__init__()in Python subclasses, with clear error messages.py_sys_model.ito use this mixin instead of the previousSuperInitCheckerand manual method wrapping.pyStatefulSysModel.ito:Basilisk.simulationpackage.SysModelMixinforStatefulSysModel, removing custom per-method wrappers.Verification
Tests
src/architecture/system_model/_UnitTest/test_PySysModel.pyandsrc/simulation/mujocoDynamics/_GeneralModuleFiles/_UnitTest/test_stateful_sys_model.pystill pass despite the refactor.Documentation
Update release notes.