-
Notifications
You must be signed in to change notification settings - Fork 90
Support setting pos and vel of MuJoCo body with 3 slider joints #1196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Will-Schwend
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR! It will be excellent to support attitude free motion explicitly.
c4c7779 to
0afadc2
Compare
schaubh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Just one small request to make MJJoint a hyperlink to the associated class in the release notes. Good to go after that change.
schaubh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the unit tests just wrapped up running and I'm getting lots of errors from simulation/mujocoDynamics/NBodyGravity/_UnitTest/test_gravity.py?
This was the culprit: I'll amend and ping you when everything passes. |
0afadc2 to
f3ea074
Compare
b17538c to
055f03b
Compare
Description
areJoints3DTranslationthat detects when the first three scalar joints are sliders aligned with x, y, z.MJBody::setPositionandMJBody::setVelocityto:MJScalarJoint:getAxis()to return the rotation axis for hinge joints or translation direction for slide joints.isHinge()to distinguish rotational from translational joints.MJJoint::checkInitializedasconstto support these const accessors.<freejoint/>intest_ball.xmlwith three orthogonal slide joints (ball_x,ball_y,ball_z).test_mass_update, set an initial position onballBodyto validate that the position can be set even through the body is not longer<freejoint/>.Verification
test_mass_update: confirms that the test passes with the 3-slider joint configuration and an arbitrary initial position set throughMJBody::setPosition.Documentation
Update release notes.