Unify structure time integration

[eulovi]

This issue was originally created by @isteinbrecher in https://gitlab.lrz.de/baci/baci/-/issues/889 on 2022-11-14.

Description

Currently, we have two implementations for the structure time integration.
In the past, this has proven to be an obstacle when developing new methods and combining them with existing ones, therefore, the two frameworks have to be unified.
To decide which one of the frameworks should be the "new" and only structural time integration, it is important to know what features of the old and new time integration are currently being used by the 4C developers.
Please add your use cases to the lists below.
If you are unsure which features you use, please ask a colleague for advice. It is very important to have an accurate picture of the current needs of all users.

Features used in the old structural time integration:

• Monolithic Fluid-Structure Interaction @mayrmt @maxfirmbach
• Mortar Meshtying & Contact with penalty @mayrmt @eulovi @lauraengelhardt
• Mortar Meshtying & Contact with Lagrange multipliers @mayrmt @eulovi @SchaefP1 @lauraengelhardt
• Poroelasticity @knarfnitram @SchaefP1
• FPSI @knarfnitram

Features used in the new structural time integration:

• Standard solid implementation @isteinbrecher @lkoeglmeier @amgebauer @c-p-schmidt @maxfirmbach @eulovi
• Beam framework (including Gen-alpha Lie group time integration) @isteinbrecher
• Beam interaction framework @isteinbrecher @maxfirmbach
• Partitioned Fluid-Structure interaction
• (Partitioned) Fluid-Beam Interaction
• Multi-Scale contact(only tested in new time integration) @RShaw026
• Runtime Output / Gauss point data output @amgebauer @isteinbrecher @maxfirmbach @eulovi
• nox @amgebauer @maxfirmbach
• material iterative prestressing @amgebauer @c-p-schmidt
• mulf @amgebauer
• cardiovascular0d @amgebauer
• Mortar Contact with penalty
• Truss implementation @c-p-schmidt
• (Partitioned) ScaTra-Structure(-Temperature) Interaction (SS(T)I) @c-p-schmidt
• Nitsche contact (for SSI) @c-p-schmidt

Related Issues and Merge Requests

• Blocks
• Is blocked by
• Follows 73
• Precedes
• Related to 57 74 88 89 93 103 136 143 145 149 228
• Part of
• Composed of

Interested Parties

[georghammerl]

This issue was originally created by @mayrmt in https://gitlab.lrz.de/baci/baci/-/issues/73 long time ago

The last comment is the relevant one as it describes the current status:

Current work in progress:

• migration of FE^2 framework
• migration of poro_p1 implementation (e.g. gen-alpha missing), c.f. Migrating poroelasticity to new time integration #146

Not yet migrated features with high priority:

• Monolithic FSI, c.f. Migrate FSI to new structural time integration #298
• Time adaptivity Monolithic FSI, c.f. Time adaptivity in new solid time integration #1537
• proper handling of Dirichlet boundary conditions at the interface, c.f. [Meshtying] cannot handle Dirichlet BCs at interface in new time integration #297
• Time adaptivity based on convergence behavior, c.f. Time adaptivity in new solid time integration #1537
• preconditioning saddle point system, c.f. Preconditioning saddle point systems in new solid time integration #1539
• meshtying/contact should be rather identical regarding implementation, however it is not. It is necessary to have a clean implementation, likely from scratch, c.f. Meshtying and contact implementation in new solid time integration #1538
• clean usage of NOX, ideally unify to single entrance point c.f. [Structure] Use NOX for non-linear solution procedure in new solid time integration #300

To be discussed if necessary immediately (or at all):

• Delete EHL implementation
• Delete MOR
• Simluation of mixed poro elements (incl. cloned fluid field) together with pure solid elements
• Poro implementation with fluid_split / structure_split
• poro with contact (Nitsche vs LM ??)
• poro-scatra with contact (Nitsche contact)
• clean up for better understability, e.g. norm calculation is done manually instead of using NOX

To be discussed after monolithic FSI is migrated (mostly based on FSI):

• FS3I
• FPS3I
• solid-ALE (wear)
• biofilm
• surface growth

[georghammerl]

In order to ease track of the issues/progress, a milestone (https://github.com/4C-multiphysics/4C/milestone/7) is created and the issues with high priority are attached to it.

[amgebauer]

@georghammerl Can we make the new solid time integration (that we already call standard) make actually the standard time integration for solid so that no-one accidentally pics the old one?

[georghammerl]

@amgebauer From my side, we can. However, some problem types (e.g. monolithic FSI, cf. #1661) are not yet migrated. In case we change the default, several test cases need an additional INT_STRATEGY: "Old" line to still run successfully.

Actually, the INT_STRATEGY flag should vanish completely. Hence, migrated problem types should not rely on that parameter at all?!

[c-p-schmidt]

My suggestion for now would be:

• make INT_STRATEGY: Standard the default
• remove all INT_STRATEGY: Standard from the input files (as in the long term, when only one time integration is left, it should vanish anyway)
• add INT_STRATEGY: Old where necessary

On my workstation, a ctest run is currently running that will show which input files are problematic. I can report later.

[amgebauer]

@georghammerl We anyway have to break old input files at some point. I think it's a good idea to make it now so that people relying on the old time integration scheme get poked once more 😄

[c-p-schmidt]

This is the summary:

96% tests passed, 122 tests failed out of 2861

The following tests FAILED:
	297 - constr2D_MPC_angle.4C.yaml-p2 (Failed)
	298 - constr2D_MPC_dist.4C.yaml-p2 (Failed)
	301 - constr3D_MPC_direct.4C.yaml-p2 (Failed)
	302 - constr3D_MPC_direct.4C.yaml-p2-pp (Not Run)
	303 - constr3D_MPC_direct_sti.4C.yaml-p2 (Failed)
	304 - constr3D_MPC_STI_trlike.4C.yaml-p2 (Failed)
	305 - constr3D_NormComp_STI.4C.yaml-p2 (Failed)
	312 - constr3D_shrinking_ost_uzawa.4C.yaml-p2 (Failed)
	318 - contact2D_binning_redist_dynamic.4C.yaml-p3 (Failed)
	319 - contact2D_binning_redist_dynamic.4C.yaml-p3-restart_20-p3 (Not Run)
	320 - contact2D_binning_redist_none.4C.yaml-p3 (Failed)
	321 - contact2D_binning_redist_none.4C.yaml-p3-restart_20-p3 (Not Run)
	322 - contact2D_binning_redist_static.4C.yaml-p3 (Failed)
	323 - contact2D_binning_redist_static.4C.yaml-p3-restart_20-p3 (Not Run)
	324 - contact2D_centrdiff.4C.yaml-p2 (Failed)
	329 - contact2D_hertz_linstatic.4C.yaml-p2 (Failed)
	338 - contact2D_lin_uzawa.4C.yaml-p2 (Failed)
	350 - contact2D_patch_bound.4C.yaml-p2 (Failed)
	352 - contact2D_patch_linstatic.4C.yaml-p2 (Failed)
	363 - contact2D_slidingblock_tresca.4C.yaml-p2 (Failed)
	376 - contact3D_lin_GPTSpenalty.4C.yaml-p2 (Failed)
	385 - contact3D_lin_uzawa.4C.yaml-p2 (Failed)
	410 - contact3D_patch_linstatic.4C.yaml-p2 (Failed)
	415 - contact3D_pwlin_penalty_hex27.4C.yaml-p2-pp (Failed)
	437 - contact3D_slidingblock_uzawa.4C.yaml-p2 (Failed)
	438 - contact3D_slidingblock_uzawa_tet10.4C.yaml-p2 (Failed)
	439 - contact3D_sp_dual_simple.4C.yaml-p3 (Failed)
	440 - contact3D_sp_std_braess_sarazin.4C.yaml-p3 (Failed)
	441 - contact3D_sp_std_simple.4C.yaml-p3 (Failed)
	442 - contact3D_sp_std_uzawa.4C.yaml-p3 (Failed)
	449 - contact3D_unbiased_self_hex8_nitsche.4C.yaml-p3 (Failed)
	808 - fps3i_reaction.4C.yaml-p2 (Failed)
	809 - fps3i_reaction.4C.yaml-p2-restart_2-p2 (Not Run)
	810 - fpsi_2D_quad4.4C.yaml-p2 (Failed)
	811 - fpsi_bending_struct.4C.yaml-p2 (Failed)
	812 - fpsi_bending_struct.4C.yaml-p2-restart_3-p2 (Not Run)
	813 - fpsi_bending_struct_BGSAMG.4C.yaml-p2 (Failed)
	814 - fpsi_ofsiinterface.4C.yaml-p2 (Failed)
	815 - fpsi_ofsiinterface.4C.yaml-p2-restart_2-p2 (Not Run)
	816 - fpsi_ofsiinterface.4C.yaml-p1 (Failed)
	817 - fpsi_ofsiinterface.4C.yaml-p1-restart_2-p1 (Not Run)
	1041 - meshtying3D_sp_dual_simple.4C.yaml-p3 (Failed)
	1044 - meshtying3D_sp_std_braess_sarazin.4C.yaml-p3 (Failed)
	1045 - meshtying3D_sp_std_simple.4C.yaml-p3 (Failed)
	1046 - meshtying3D_sp_std_simple_nbinterfaceagg.4C.yaml-p3 (Failed)
	1047 - meshtying3D_sp_std_uzawa.4C.yaml-p3 (Failed)
	1145 - orthopressure_solidw6.4C.yaml-p2-pp (Failed)
	1364 - plastic_necking_fbar_thrplast.4C.yaml-p2 (Failed)
	1365 - plastic_necking_fbar_thrplast.4C.yaml-p2-restart_10-p2 (Not Run)
	1371 - poro_2D_contact_closed_bound.4C.yaml-p2 (Failed)
	1383 - poro_2D_psi_quad9_br_flsplit.4C.yaml-p2 (Failed)
	1384 - poro_2D_quad4_br_flsplit_dbc.4C.yaml-p2 (Failed)
	1385 - poro_2D_quad4_br_flsplit_dbc.4C.yaml-p2-restart_5-p2 (Not Run)
	1386 - poro_2D_quad4_br_flsplit_dbc.4C.yaml-p1 (Failed)
	1387 - poro_2D_quad4_br_flsplit_nbc.4C.yaml-p2 (Failed)
	1388 - poro_2D_quad4_br_stsplit_dbc.4C.yaml-p2 (Failed)
	1389 - poro_2D_quad4_br_stsplit_nbc.4C.yaml-p2 (Failed)
	1390 - poro_2D_quad4_br_stsplit_nbc.4C.yaml-p1 (Failed)
	1391 - poro_2D_quad4_br_stsplit_nbc.4C.yaml-p1-restart_40-p1 (Not Run)
	1392 - poro_2D_quad4_const_material_nodal_orthotropic_permeability.4C.yaml-p2 (Failed)
	1393 - poro_2D_quad4_const_material_nodal_orthotropic_permeability.4C.yaml-p2-restart_10-p2 (Not Run)
	1395 - poro_2D_quad4_meshtying.4C.yaml-p2 (Failed)
	1396 - poro_2D_quad4_nopen.4C.yaml-p2 (Failed)
	1397 - poro_2D_quad4_nopen.4C.yaml-p2-restart_15-p2 (Not Run)
	1398 - poro_2D_quad4_p1_constporo.4C.yaml-p2 (Failed)
	1399 - poro_2D_quad4_p1_conv_term_supg.4C.yaml-p1 (Failed)
	1400 - poro_2D_quad4_p1_conv_term.4C.yaml-p1 (Failed)
	1401 - poro_2D_quad4_p1.4C.yaml-p1 (Failed)
	1402 - poro_2D_quad4_poroporocontact.4C.yaml-p2 (Failed)
	1403 - poro_2D_quad4_porosolid_mt_patchtest.4C.yaml-p2 (Failed)
	1406 - poro_2D_quad9_p1.4C.yaml-p2 (Failed)
	1407 - poro_2D_scatra_ecm_reaction.4C.yaml-p2 (Failed)
	1413 - poro_2D_tri3_biot_stab_p1.4C.yaml-p2 (Failed)
	1414 - poro_2D_volmortar_tri_tri.4C.yaml-p2 (Failed)
	1415 - poro_3D_br_hex8_fl_split_dbc.4C.yaml-p2 (Failed)
	1416 - poro_3D_br_hex8_fl_split_nbc.4C.yaml-p2 (Failed)
	1417 - poro_3D_br_hex8_st_split_dbc.4C.yaml-p2 (Failed)
	1418 - poro_3D_br_hex8_st_split_nbc.4C.yaml-p2 (Failed)
	1425 - poro_3D_hex8_const_material_nodal_orthotropic_permeability.4C.yaml-p2 (Failed)
	1426 - poro_3D_hex8_const_material_nodal_orthotropic_permeability.4C.yaml-p2-restart_10-p2 (Not Run)
	1434 - poro_3D_hex8_nopenetration.4C.yaml-p2 (Failed)
	1435 - poro_3D_hex8_p1.4C.yaml-p2 (Failed)
	1436 - poro_3D_hex8_p1.4C.yaml-p2-restart_5-p2 (Not Run)
	1438 - poro_3D_hex8_stat.4C.yaml-p1 (Failed)
	1449 - poro_scatra_contact3D_two_cubes.4C.yaml-p2 (Failed)
	1450 - poro_solid_contact3D_twoelem.4C.yaml-p2 (Failed)
	1451 - poro_solid_contact3D_twoelem_wonopen.4C.yaml-p2 (Failed)
	1453 - poro_solid_nitsche_contact3D_twoelem_twosided.4C.yaml-p2 (Failed)
	1920 - solid_ele_nurbs27_periodic_patches_with_ls_dirichlet.4C.yaml-p2 (Failed)
	1921 - solid_ele_nurbs27_periodic_patches_with_ls_dirichlet.4C.yaml-p2-restart_1-p2 (Not Run)
	1999 - solid_ele_viscoelasthyper.4C.yaml-p2-restart_50-p2 (Failed)
	2018 - solid_nodal_fiber.4C.yaml-p2 (Failed)
	2086 - sonurbs27.4C.yaml-p3 (Failed)
	2095 - sosh8_freeflying_ruler_sta_ab2.4C.yaml-p2 (Failed)
	2097 - sosh8_freeflying_ruler_sta_centrdiff.4C.yaml-p2 (Failed)
	2101 - sosh8_freeflying_ruler_sta_expleuler.4C.yaml-p1 (Failed)
	2105 - sosh8_lin_bending_patchtest.4C.yaml-p2 (Failed)
	2109 - soshw6_thin_nonlinear_pinched_hemisphere.4C.yaml-p2-pp (Failed)
	2111 - sotet10_cooks_nl.4C.yaml-p2-pp (Failed)
	2129 - spring_dashpot_struct_bc_curnormal.4C.yaml-p2 (Failed)
	2288 - strufem_tet10_disp_cantilever.4C.yaml-p2-pp (Failed)
	2290 - strufem_tet4_disp_cantilever.4C.yaml-p2-pp (Failed)
	2292 - strufem_wedge6_disp_cantilever.4C.yaml-p2-pp (Failed)
	2366 - viscoelasthyper.4C.yaml-p2-restart_50-p2 (Failed)
	2388 - w1nurbs9_pbc.4C.yaml-p2 (Failed)
	2389 - w1nurbs9_pbc.4C.yaml-p2-restart_15-p2 (Not Run)
	2391 - w1q4_cantilever_eas.4C.yaml-p2-pp (Failed)
	2393 - w1q4_patch_eas.4C.yaml-p2-pp (Failed)
	2395 - w1q8_patch_nonlinear.4C.yaml-p2-pp (Failed)
	2397 - w1q9_dyn_rot_drt_gena.4C.yaml-p2-pp (Failed)
	2399 - w1t6_patch_linear.4C.yaml-p2-pp (Failed)
	2607 - xfp_comp_struct_2D_mono.4C.yaml-p3 (Failed)
	2608 - xfpi_2D_mixedflow_BJ.4C.yaml-p2 (Failed)
	2609 - xfpi_2D_mixedflow_BJ_edgeb.4C.yaml-p2 (Failed)
	2610 - xfpi_2D_mixedflow_BJ_Sub.4C.yaml-p2 (Failed)
	2611 - xfpi_2D_mixedflow_BJ_varporosity_KC.4C.yaml-p2 (Failed)
	2612 - xfpi_2D_mixedflow_BJS.4C.yaml-p2 (Failed)
	2613 - xfpi_2D_mixedflow_BJS_varporosity.4C.yaml-p2 (Failed)
	2614 - xfpi_2D_normalflow.4C.yaml-p2 (Failed)
	2615 - xfpi_2D_tangentialflow_BJ.4C.yaml-p2 (Failed)
	2616 - xfpsci_twoelem_pp.4C.yaml-p2 (Failed)
	2617 - xfpsci_twoelem_ps.4C.yaml-p2 (Failed)