image hash for sapient signers always defined

Author: ScreamingHawk

packages/wallet/core/src/signers/index.ts

@@ -20,7 +20,7 @@ export interface Signer {
 
 export interface SapientSigner {
   readonly address: MaybePromise<Address.Address>
-  readonly imageHash: MaybePromise<Hex.Hex | undefined>
+  readonly imageHash: MaybePromise<Hex.Hex>
 
   signSapient: (
     wallet: Address.Address,

packages/wallet/core/src/signers/session-manager.ts

@@ -49,15 +49,15 @@ export class SessionManager implements SapientSigner {
     this._provider = options.provider
   }
 
-  get imageHash(): Promise<Hex.Hex | undefined> {
+  get imageHash(): Promise<Hex.Hex> {
     return this.getImageHash()
   }
 
-  async getImageHash(): Promise<Hex.Hex | undefined> {
+  async getImageHash(): Promise<Hex.Hex> {
     const { configuration } = await this.wallet.getStatus()
     const sessionConfigLeaf = Config.findSignerLeaf(configuration, this.address)
     if (!sessionConfigLeaf || !Config.isSapientSignerLeaf(sessionConfigLeaf)) {
-      return undefined
+      throw new Error(`Session configuration not found for wallet ${this.wallet.address}`)
     }
     return sessionConfigLeaf.imageHash
   }

packages/wallet/dapp-client/src/ChainSessionManager.ts

@@ -898,9 +898,7 @@ export class ChainSessionManager {
         ...envelope.payload,
         parentWallets: [this.wallet.address],
       }
-      const imageHash = await this.sessionManager.imageHash
-      if (imageHash === undefined) throw new SessionConfigError('Session manager image hash is undefined')
-
+      const imageHash = await this.sessionManager.getImageHash()
       const signature = await this.sessionManager.signSapient(
         this.wallet.address,
         this.chainId,