chore: increase cycles limit for ntxs to 256k (#1836)

Author: SantiagoPittella

bin/node/src/commands/mod.rs

@@ -53,7 +53,7 @@ const ENV_NTX_MAX_CYCLES: &str = "MIDEN_NTX_MAX_CYCLES";
 const DEFAULT_NTX_TICKER_INTERVAL: Duration = Duration::from_millis(200);
 const DEFAULT_NTX_IDLE_TIMEOUT: Duration = Duration::from_secs(5 * 60);
 const DEFAULT_NTX_SCRIPT_CACHE_SIZE: NonZeroUsize = NonZeroUsize::new(1000).unwrap();
-const DEFAULT_NTX_MAX_CYCLES: u32 = 1 << 16;
+const DEFAULT_NTX_MAX_CYCLES: u32 = 1 << 18;
 
 /// Configuration for the Validator key used to sign blocks.
 ///
@@ -199,7 +199,7 @@ pub struct NtxBuilderConfig {
 
     /// Maximum number of VM execution cycles allowed for a single network transaction.
     ///
-    /// Network transactions that exceed this limit will fail. Defaults to 2^16 (65536) cycles.
+    /// Network transactions that exceed this limit will fail. Defaults to 2^18 (262.144) cycles.
     #[arg(
         long = "ntx-builder.max-cycles",
         env = ENV_NTX_MAX_CYCLES,

bin/node/src/tests.rs

@@ -38,5 +38,6 @@ fn bundled_start_parses() {
 
 #[test]
 fn bundled_start_with_max_cycles_parses() {
-    let _ = parse(&["bundled", "start", "--ntx-builder.max-cycles", "131072"]);
+    let max_cycles = 2_i32.pow(18).to_string();
+    let _ = parse(&["bundled", "start", "--ntx-builder.max-cycles", &max_cycles]);
 }

crates/ntx-builder/src/actor/mod.rs

@@ -112,7 +112,7 @@ impl AccountActorContext {
             idle_timeout: Duration::from_secs(60),
             db: db.clone(),
             request_tx,
-            max_cycles: 1 << 16,
+            max_cycles: 1 << 18,
         }
     }
 }

crates/ntx-builder/src/lib.rs

@@ -71,7 +71,7 @@ const DEFAULT_MAX_ACCOUNT_CRASHES: usize = 10;
 ///
 /// This limits the computational cost of network transactions. The protocol maximum is
 /// `1 << 29` but network transactions should be much cheaper.
-const DEFAULT_MAX_TX_CYCLES: u32 = 1 << 16;
+const DEFAULT_MAX_TX_CYCLES: u32 = 1 << 19;
 
 // CONFIGURATION
 // =================================================================================================
@@ -128,7 +128,7 @@ pub struct NtxBuilderConfig {
     /// Maximum number of VM execution cycles allowed for a single network transaction.
     ///
     /// Network transactions that exceed this limit will fail with an execution error.
-    /// Defaults to 64k cycles.
+    /// Defaults to 2^18 cycles.
     pub max_cycles: u32,
 
     /// Path to the SQLite database file used for persistent state.